fix: Bump MSRV (#291)

* fix: Bump MSRV and add unsafes

* fix: Docker readme file

Author: tirumerla

.github/workflows/release-docker.yml

@@ -91,7 +91,7 @@ jobs:
           password: ${{ secrets.DOCKERHUB_PAT }}
           repository: ${{ env.DOCKERHUB_IMAGE }}
           short-description: ${{ github.event.repository.description }}
-          readme-filepath: ./DOCKERHUB_README.md
+          readme-filepath: ./DOCKER_README.md
       - name: Slack notification success or failure
         uses: act10ns/slack@44541246747a30eb3102d87f7a4cc5471b0ffb7d  # v2.1.0
         with:

Cargo.toml

@@ -2,7 +2,7 @@
 name = "openzeppelin-monitor"
 version = "1.0.0"
 edition = "2021"
-rust-version = "1.84"         #MSRV
+rust-version = "1.86"         #MSRV
 
 [profile.release]
 opt-level = 0

docs/modules/ROOT/pages/index.adoc

@@ -240,7 +240,7 @@ The monitor implements protocol security validations across different components
 * *Warning*: Using other ports will trigger security warnings
 * *Valid Format*: Email addresses must follow RFC 5322 format
 
-====== Notifcations Retry Policy
+====== Notifications Retry Policy
 
 Following notification protocols support retry policies:
 

src/services/blockchain/transports/endpoint_manager.rs

@@ -292,7 +292,8 @@ impl EndpointManager {
 						if ROTATE_ON_ERROR_CODES.contains(&status.as_u16()) {
 							tracing::debug!(
 								"send_raw_request: HTTP status {} on '{}' triggers URL rotation attempt",
-								status, current_url_snapshot
+								status,
+								current_url_snapshot
 							);
 
 							match self.try_rotate_url(transport).await {
@@ -338,7 +339,10 @@ impl EndpointManager {
 					// Always attempt rotation on network errors
 					match self.try_rotate_url(transport).await {
 						Ok(new_url) => {
-							tracing::debug!("Rotation successful after network error, retrying request on new URL: '{}'", new_url);
+							tracing::debug!(
+								"Rotation successful after network error, retrying request on new URL: '{}'",
+								new_url
+							);
 							continue; // Retry on the new active URL
 						}
 						Err(rotation_error) => {

src/services/filter/filters/evm/evaluator.rs

@@ -117,8 +117,8 @@ impl<'a> EVMConditionEvaluator<'a> {
 				} else {
 					// For Eq/Ne, a number literal cannot be equal to a JSON array string.
 					let msg = format!(
-							"Expected string literal (representing a JSON array) for EVM 'array' Eq/Ne comparison, found number: {:?}",
-							rhs_literal
+						"Expected string literal (representing a JSON array) for EVM 'array' Eq/Ne comparison, found number: {:?}",
+						rhs_literal
 					);
 					return Err(EvaluationError::type_mismatch(msg, None, None));
 				}
@@ -167,8 +167,8 @@ impl<'a> EVMConditionEvaluator<'a> {
 				// Ensure both parsed values are actually arrays
 				if !lhs_json_value.is_array() || !rhs_json_value.is_array() {
 					let msg = format!(
-							"For 'array' Eq/Ne comparison, both LHS ('{}') and RHS ('{}') must resolve to JSON arrays.",
-							lhs_json_array_str, rhs_target_str
+						"For 'array' Eq/Ne comparison, both LHS ('{}') and RHS ('{}') must resolve to JSON arrays.",
+						lhs_json_array_str, rhs_target_str
 					);
 					return Err(EvaluationError::type_mismatch(msg, None, None));
 				}
@@ -572,9 +572,9 @@ impl<'a> EVMConditionEvaluator<'a> {
 					serde_json::from_str::<serde_json::Map<String, JsonValue>>(lhs_json_map_str)
 						.map_err(|e| {
 							let msg = format!(
-						"Failed to parse LHS value '{}' as JSON map for 'contains' operator",
-						lhs_json_map_str
-					);
+								"Failed to parse LHS value '{}' as JSON map for 'contains' operator",
+								lhs_json_map_str
+							);
 							EvaluationError::parse_error(msg, Some(e.into()), None)
 						})?;
 

src/services/filter/filters/stellar/evaluator.rs

@@ -158,7 +158,8 @@ impl<'a> StellarConditionEvaluator<'a> {
 					// Fallback to CSV
 					tracing::debug!(
 						"LHS for 'vec' ('{}') not valid JSON array, falling back to CSV check for value '{}'",
-						lhs_str, rhs_target_str
+						lhs_str,
+						rhs_target_str
 					);
 					let csv_values: Vec<&str> = lhs_str.split(',').map(str::trim).collect();
 					Ok(csv_values.contains(&rhs_target_str))
@@ -474,9 +475,9 @@ impl<'a> StellarConditionEvaluator<'a> {
 					serde_json::from_str::<serde_json::Map<String, JsonValue>>(lhs_json_map_str)
 						.map_err(|e| {
 							let msg = format!(
-						"Failed to parse LHS value '{}' as JSON map for 'contains' operator",
-						lhs_json_map_str
-					);
+								"Failed to parse LHS value '{}' as JSON map for 'contains' operator",
+								lhs_json_map_str
+							);
 							EvaluationError::parse_error(msg, Some(e.into()), None)
 						})?;
 

src/services/notification/mod.rs

@@ -188,7 +188,7 @@ impl NotificationService {
 							"Invalid email configuration".to_string(),
 							None,
 							None,
-						))
+						));
 					}
 				};
 
@@ -222,7 +222,7 @@ impl NotificationService {
 							"Invalid script configuration".to_string(),
 							None,
 							None,
-						))
+						));
 					}
 				};
 				let script = trigger_scripts
@@ -241,7 +241,7 @@ impl NotificationService {
 				let script_content = match &script {
 					Ok(content) => content,
 					Err(e) => {
-						return Err(NotificationError::config_error(e.to_string(), None, None))
+						return Err(NotificationError::config_error(e.to_string(), None, None));
 					}
 				};
 

src/services/notification/telegram.rs

@@ -234,7 +234,7 @@ impl Notifier for TelegramNotifier {
 
 		// Send the notification using the inner Webhook notifier
 		self.inner
-			// TODO: The `message` parameter is required by the Notifier trait for generic 
+			// TODO: The `message` parameter is required by the Notifier trait for generic
 			// webhook signing, but it's duplicated in this specific payload
 			.notify_with_payload(message, payload_fields)
 			.await
@@ -383,7 +383,9 @@ mod tests {
 	fn test_escape_markdown_v2() {
 		// Test for real life examples
 		assert_eq!(
-			TelegramNotifier::escape_markdown_v2("*Transaction Alert*\n*Network:* Base Sepolia\n*From:* 0x00001\n*To:* 0x00002\n*Transaction:* [View on Blockscout](https://base-sepolia.blockscout.com/tx/0x00003)"),
+			TelegramNotifier::escape_markdown_v2(
+				"*Transaction Alert*\n*Network:* Base Sepolia\n*From:* 0x00001\n*To:* 0x00002\n*Transaction:* [View on Blockscout](https://base-sepolia.blockscout.com/tx/0x00003)"
+			),
 			"*Transaction Alert*\n*Network:* Base Sepolia\n*From:* 0x00001\n*To:* 0x00002\n*Transaction:* [View on Blockscout](https://base\\-sepolia\\.blockscout\\.com/tx/0x00003)"
 		);
 

src/utils/monitor/execution.rs

@@ -260,14 +260,14 @@ pub async fn execute_monitor<
 					"Midnight network not supported",
 					None,
 					None,
-				))
+				));
 			}
 			BlockChainType::Solana => {
 				return Err(MonitorExecutionError::execution_error(
 					"Solana network not supported",
 					None,
 					None,
-				))
+				));
 			}
 		};
 

tests/integration/bootstrap/main.rs

@@ -151,10 +151,12 @@ async fn test_initialize_services() {
 		"TriggerExecutionService should be wrapped in Arc"
 	);
 
-	assert!(active_monitors.iter().any(|m| m.name == "test"
-		&& m.networks.contains(&"ethereum_mainnet".to_string())
-		&& m.triggers
-			.contains(&"evm_large_transfer_usdc_slack".to_string())));
+	assert!(active_monitors.iter().any(|m| {
+		m.name == "test"
+			&& m.networks.contains(&"ethereum_mainnet".to_string())
+			&& m.triggers
+				.contains(&"evm_large_transfer_usdc_slack".to_string())
+	}));
 	assert!(networks.contains_key("ethereum_mainnet"));
 
 	assert!(Arc::strong_count(&monitor_service) >= 1);