Crashes clients with fabric mods that use ConfigurationTasks

[purejosh]

Hello. I know that Velocity is still improving its stability with Fabric modded servers, so I wanted to report another bug.

There's a mod called MightyMail, which sends a config packet to clients on login, however these packets are unable to traverse through the proxy. This causes mods like MM to crash when the items are used, as the config packet didn't make it to the client.

The developer for MM said that Velocity would need to support custom ConfigurationTasks, which is a vanilla feature. Does a plugin exist that allows this to work? Or, as a developer that might be more familiar with how Velocity works, is support for ConfigurationTasks possible?

I really want to help make Velocity the absolute best proxy, so anything I can do to help, I will.

[456dev]

i've just tested without fabric (directly patching vanilla minecraft itself, see this fork of mache)
and was able to add and receive a custom configuration task both with and without velocity, with no changes.

i dont know what fabric does differently (thats next for me to test), but this doesn't seem like a velocity issue?

[electronicboy]

The start and the end of the configuration phase are both well marked with two separate packets, and so there's no need for velocity to care about custom configuration phases as we just wait on the server to tell us when its done configuring the client before we can proceed with actually bumping the client out of that phase.

I'm not really sure what MM is doing here, their repo is pre configuration phase existing, and they're not doing anything in their existing repo that would break with a proxy.

[456dev]

ive found the issue, its on MightyMails side (sort of). it uses MrCrayfish/Framework, which uses login plugin messages on <1.20.2 (which makes sense, as the config phase didnt exist before then anyway.)

[electronicboy]

Yea, login messages are 100% a no-go until 1.20.5, in which at that point we miiiight be able to get something that will support that stuff a bit better (but, is a chunky engineering effort I want to get to but can't really commit to...)