Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When forced-hosts section in config is gone, errors appear #1375

Open
svaningelgem opened this issue Jul 6, 2024 · 5 comments
Open

When forced-hosts section in config is gone, errors appear #1375

svaningelgem opened this issue Jul 6, 2024 · 5 comments
Labels
type: bug Something isn't working

Comments

@svaningelgem
Copy link

Expected Behavior

The server should start.

Actual Behavior

The server crashes with this error:

[10:30:15 ERROR]: Server 'factions' for forced host 'factions.example.com' does not exist
[10:30:15 ERROR]: Server 'minigames' for forced host 'minigames.example.com' does not exist
[10:30:15 ERROR]: Your configuration is invalid. Velocity will not start up until the errors are resolved.

Steps to Reproduce

Just remove that section.
If it matters, my servers section was:

[servers]
	lobby = "1.2.3.4:25576"
	try = ["lobby"]

Plugin List

None

Velocity Version

3.3.0

Additional Information

No response

@svaningelgem svaningelgem added the type: bug Something isn't working label Jul 6, 2024
@Nacioszeczek
Copy link
Member

While I do think this should be fixed, in the meantime you can just put forced-hosts = {} in your config.

@svaningelgem
Copy link
Author

svaningelgem commented Jul 6, 2024

That's what I basically did 😉.

But I thought it shouldn't happen like this, so I reported this as a bug.
There is still some hardcoded stuff in velocity that shouldn't be there imho.

Low prio bug

@electronicboy
Copy link
Member

the specific outcome here isn't a bug, the bug is that the default values are not written back to the disk. Pretty much anything in existence, if you remove the configuration options for, will use the default ones

@svaningelgem
Copy link
Author

imho, the question should be: should velocity force factions/minigames/lobby default on all their users?
Shouldn't the "servers" keys be in the forced hosts only?

@electronicboy
Copy link
Member

That's a bad question, because velocity is not forcing them on you, you are more than welcome to remove them, but, like anything, a default configuration file exists to showcase how to configure the software without requiring that you create the file by hand.

You are more than welcome to remove the entries in that section, deleting the section itself however will use the defaults

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants