Unused assignment

[Daniel-Cortez]

The following code in function stmt_close() looks suspicious:

MySQL-Prepared-Statements/mysql_prepared.inc

Lines 123 to 127 in 3c781e5

	// reset data.
	gs_Statements[statement][E_STMT_MYSQL_HANDLE] = INVALID_CONNECTION;
	statement = INVALID_STATEMENT;
	return true;
	}

The assignment statement = INVALID_STATEMENT; seems to be unused (statement is neither passed by reference nor a global variable). Was this intended?

[PatrickGTR]

Hello, sorry for a really long late reply. I just seen this.

iirc it is used to free up a statements. statements that requires one time use only, but another alternative is to bump up the value of MAX_STATEMENTS

[Daniel-Cortez]

iirc it is used to free up a statements. statements that requires one time use only

I didn't mean the whole function, I only meant the line statement = INVALID_STATEMENT; which seems to be redundant code, as the value assigned to statement on that line is unused upon return.
I discovered it with this new feature (currently pending approval).

[PatrickGTR]

After reading, it makes sense! Thanks for bringing this up.

#4 #