Skip to content

Commit 3ff3b60

Browse files
committed
fix(pat inject): Fix closing of panels after successful inject.
Fix case where close-panel event was suppressed while injection is in progress but suppressing was never released. This prevented any other close-panel events from being handled properly.
1 parent 6b128bf commit 3ff3b60

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/pat/inject/inject.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -768,11 +768,11 @@ const inject = {
768768
// Wait for the next tick to ensure that the close-panel listener
769769
// is called before this one, even for non-async local injects.
770770
await utils.timeout(1);
771+
// Remove the close-panel event listener.
772+
events.remove_event_listener($el[0], "pat-inject--close-panel");
771773
// Only close the panel if a close-panel event was catched previously.
772774
if (do_close_panel) {
773775
do_close_panel = false;
774-
// Remove the close-panel event listener.
775-
events.remove_event_listener($el[0], "pat-inject--close-panel");
776776
// Re-trigger close-panel event if it was caught while injection was in progress.
777777
$el[0].dispatchEvent(
778778
new Event("close-panel", { bubbles: true, cancelable: true })

0 commit comments

Comments
 (0)