Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict owning entity when querying characteristics #1320

Open
arteymix opened this issue Jan 25, 2025 · 0 comments
Open

Restrict owning entity when querying characteristics #1320

arteymix opened this issue Jan 25, 2025 · 0 comments
Labels
enhancement Enhance the code or user experience low priority

Comments

@arteymix
Copy link
Member

Methods in CharacteristicDao should always take in a collection of owning entity classes to avoid exposing characteristics from unexpected origin.

In particular the following are likely not a good thing to expose since they are generally free-text or not curated:

  • cell type annotation
  • cell-level characteristics
  • biomaterial characteristics (mostly free text from GEO)

I've added the logic for creating a clause, so this is just about applying it consistently.

@arteymix arteymix added enhancement Enhance the code or user experience low priority labels Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhance the code or user experience low priority
Projects
None yet
Development

No branches or pull requests

1 participant