Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use smart pointer for node trees #48

Open
pfrommerd opened this issue Oct 13, 2020 · 1 comment
Open

Use smart pointer for node trees #48

pfrommerd opened this issue Oct 13, 2020 · 1 comment
Assignees
@wvauclain
Labels
good first issue Good for newcomers

Comments

@pfrommerd
Copy link
Collaborator

Make groups use unique_ptr for managing children to reduce the chance of a memory leak.
@pfrommerd pfrommerd added the good first issue Good for newcomers label Oct 13, 2020
@wvauclain wvauclain self-assigned this Nov 12, 2020
@wvauclain
Copy link
Contributor

@pfrommerd mentioned getting valgrind set up to work with our coroutines so that we can check out this and other memory leaks as a good first step

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wvauclain wvauclain

Labels
good first issue Good for newcomers
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pfrommerd @wvauclain