[516 Fixes] Pentest 516 Branch Fixes#589
Conversation
Port of ParadiseSS13/Paradise#27676 and VOREStation/VOREStation#16734 > Instead of relying on `is-disabled` and `is-visible`, which BYOND happily will automatically change for you whenever you send a client text, we now use a Child element to swap between the legacy output and browser output in separate preset panes. > > TL;DR: chat would flash white under 516, now doesn't I cleared cache before each test video below, just to be 100% sure <details> <summary>Testing Evidence: BYOND 515</summary> https://github.com/user-attachments/assets/8d661cc3-585e-4f8e-9399-76df8bc0a281 </details> <details> <summary>Testing Evidence: BYOND 516</summary> https://github.com/user-attachments/assets/c0d31fb4-6ef5-4d49-81a8-c767c5e24cc2 </details> flickering chat hurts my eyes :cl: Absolucy, ShadowLarkens, S34N fix: Fixed chat rapidly flickering in BYOND 516. /:cl:
Ossa88
changed the title
|
Had to apply additional edits from the original Const version due to TRIDENT (Internet Explorer) basically being pulled from the code. |
…re later isnt it?
Co-authored-by: Lucy <lucy@absolucy.moe>
…into moar-516-fixes
|
Just realized this is TMed... meaning it is not working in stopping the chat zlevel fighting |
|
This PR has been inactive for a month. This means it is at risk of being auto closed in a week, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
2 participants
About The Pull Request
I am reviewing the 516 Pentest Branch for fixes we applied that Shiptest just has not corrected.
Paperwork can now accept more than 2kb of data per save
Chat will properly scroll down and stop fighting.
Why It's Good For The Game
Having working code is more important than maintaining modularization after some point
Changelog
🆑
fix: Paperwork can accept more than 2kb of data per post.
fix: Chat will properly scroll down again.
/:cl: