PS-9217: Merge MySQL 8.0.37 Fix warnings with gcc-14

https://perconadev.atlassian.net/browse/PS-9217

Author: VarunNagaraju

libbinlogevents/include/binlog_event.h

@@ -730,7 +730,14 @@ class Log_event_header {
     @return True if the event object is valid, false otherwise.
   */
 
+#if defined(__GNUC__) && (__GNUC__ >= 14)
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wuninitialized"
+#endif
   bool get_is_valid() { return m_is_valid; }
+#if defined(__GNUC__) && (__GNUC__ >= 14)
+#pragma GCC diagnostic pop
+#endif
 
   /**
     Set if the event object shall be considered valid or not.

plugin/audit_log_filter/event_filter_function/query_digest.h

@@ -26,8 +26,7 @@ template <>
 class EventFilterFunction<EventFilterFunctionType::QueryDigest>
     : public EventFilterFunctionBase {
  public:
-  explicit EventFilterFunction<EventFilterFunctionType::QueryDigest>(
-      FunctionArgsList args);
+  explicit EventFilterFunction(FunctionArgsList args);
 
   /**
    * @brief Validate function arguments.

plugin/audit_log_filter/event_filter_function/string_find.h

@@ -24,8 +24,7 @@ template <>
 class EventFilterFunction<EventFilterFunctionType::StringFind>
     : public EventFilterFunctionBase {
  public:
-  explicit EventFilterFunction<EventFilterFunctionType::StringFind>(
-      FunctionArgsList args);
+  explicit EventFilterFunction(FunctionArgsList args);
 
   /**
    * @brief Validate function arguments.

plugin/audit_log_filter/log_writer/file.h

@@ -31,10 +31,10 @@ using FileWriterPtr = std::unique_ptr<FileWriterBase>;
 template <>
 class LogWriter<AuditLogHandlerType::File> : public LogWriterBase {
  public:
-  LogWriter<AuditLogHandlerType::File>() = delete;
-  explicit LogWriter<AuditLogHandlerType::File>(
+  LogWriter() = delete;
+  explicit LogWriter(
       std::unique_ptr<log_record_formatter::LogRecordFormatterBase> formatter);
-  ~LogWriter<AuditLogHandlerType::File>() override;
+  ~LogWriter() override;
 
   /**
    * @brief Init log writer.

plugin/percona-pam-for-mysql/src/auth_pam_common.cc

@@ -80,7 +80,7 @@ static int vio_server_conv(int num_msg, const struct pam_message **msg,
     return PAM_CONV_ERR;
   }
 
-  *resp = (struct pam_response *)calloc(sizeof(struct pam_response), num_msg);
+  *resp = (struct pam_response *)calloc(num_msg, sizeof(struct pam_response));
   if (*resp == nullptr) return PAM_BUF_ERR;
 
   void *talk_data;

router/tests/component/test_routing_strategy.cc

@@ -413,7 +413,7 @@ TEST_P(RouterRoutingStrategyMetadataCache, MetadataCacheRoutingStrategy) {
       ASSERT_NO_FATAL_FAILURE(
           connect_client_and_query_port(router_port, node_port));
       if (i == 0) {  // first-connection
-        const auto &real_port_iter =
+        const auto real_port_iter =
             std::find(cluster_nodes_ports.begin(), cluster_nodes_ports.end(),
                       static_cast<uint16_t>(std::atoi(node_port.c_str())));
         ASSERT_NE(real_port_iter, cluster_nodes_ports.end());

sql/auth/acl_table_user.cc

@@ -2074,32 +2074,6 @@ bool Acl_table_user_reader::driver() {
 Password_lock::Password_lock()
     : password_lock_time_days(0), failed_login_attempts(0) {}
 
-Password_lock &Password_lock::operator=(const Password_lock &other) {
-  if (this != &other) {
-    password_lock_time_days = other.password_lock_time_days;
-    failed_login_attempts = other.failed_login_attempts;
-  }
-  return *this;
-}
-
-Password_lock &Password_lock::operator=(Password_lock &&other) {
-  if (this != &other) {
-    std::swap(password_lock_time_days, other.password_lock_time_days);
-    std::swap(failed_login_attempts, other.failed_login_attempts);
-  }
-  return *this;
-}
-
-Password_lock::Password_lock(const Password_lock &other) {
-  password_lock_time_days = other.password_lock_time_days;
-  failed_login_attempts = other.failed_login_attempts;
-}
-
-Password_lock::Password_lock(Password_lock &&other) {
-  std::swap(password_lock_time_days, other.password_lock_time_days);
-  std::swap(failed_login_attempts, other.failed_login_attempts);
-}
-
 }  // namespace acl_table
 
 /**

sql/auth/acl_table_user.h

@@ -73,13 +73,6 @@ struct Password_lock {
 
   Password_lock();
 
-  Password_lock &operator=(const Password_lock &other);
-
-  Password_lock &operator=(Password_lock &&other);
-
-  Password_lock(const Password_lock &other);
-
-  Password_lock(Password_lock &&other);
 };
 
 /**

sql/log_event.cc

@@ -1010,11 +1010,18 @@ Log_event::Log_event(Log_event_header *header, Log_event_footer *footer)
       common_footer(footer) {
 #ifdef MYSQL_SERVER
   thd = nullptr;
+#endif
+#if defined(__GNUC__) && (__GNUC__ >= 14)
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wuninitialized"
 #endif
   /*
      Mask out any irrelevant parts of the server_id
   */
   server_id = common_header->unmasked_server_id & opt_server_id_mask;
+#if defined(__GNUC__) && (__GNUC__ >= 14)
+#pragma GCC diagnostic pop
+#endif
 }
 
 /*
@@ -7977,6 +7984,10 @@ Rows_log_event::Rows_log_event(
      for UPDATE_ROWS_EVENTS, else it is equal to the before image.
   */
   /* if bitmap_init fails, is_valid will be set to false */
+#if defined(__GNUC__) && (__GNUC__ >= 14)
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
+#endif
   if (likely(!bitmap_init(&m_cols,
                           m_width <= sizeof(m_bitbuf) * 8 ? m_bitbuf : nullptr,
                           m_width))) {
@@ -7996,6 +8007,9 @@ Rows_log_event::Rows_log_event(
     common_header->set_is_valid(false);
     return;
   }
+#if defined(__GNUC__) && (__GNUC__ >= 14)
+#pragma GCC diagnostic pop
+#endif
   m_cols_ai.bitmap =
       m_cols.bitmap;  // See explanation below while setting is_valid.
 

sql/sql_bitmap.h

@@ -139,10 +139,10 @@ class Bitmap<64> {
   ulonglong map;
 
  public:
-  Bitmap<64>() { init(); }
+  Bitmap() { init(); }
   enum { ALL_BITS = 64 };
 
-  explicit Bitmap<64>(uint prefix_to_set) { set_prefix(prefix_to_set); }
+  explicit Bitmap(uint prefix_to_set) { set_prefix(prefix_to_set); }
   void init() { clear_all(); }
   void init(uint prefix_to_set) { set_prefix(prefix_to_set); }
   uint length() const { return 64; }

sql/sql_planner.cc

@@ -1085,6 +1085,10 @@ void Optimize_table_order::best_access_path(JOIN_TAB *tab,
         choose it over ALL/index, there is no need to consider a full table
         scan.
   */
+#if defined(__GNUC__) && (__GNUC__ >= 14)
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Warray-bounds"
+#endif
   if (rows_fetched < tab->found_records &&  // (1a)
       best_read_cost <= tab->read_time)     // (1b)
   {
@@ -1190,6 +1194,9 @@ void Optimize_table_order::best_access_path(JOIN_TAB *tab,
 
     trace_access_scan.add("chosen", best_ref == nullptr);
   }
+#if defined(__GNUC__) && (__GNUC__ >= 14)
+#pragma GCC diagnostic pop
+#endif
 
   /*
     Storage engines that track exact sizes may report an empty table

sql/stream_cipher.cc

@@ -69,7 +69,7 @@ bool Aes_ctr_cipher<TYPE>::open(const Key_string &password, int header_size) {
 }
 
 template <Cipher_type TYPE>
-Aes_ctr_cipher<TYPE>::~Aes_ctr_cipher<TYPE>() {
+Aes_ctr_cipher<TYPE>::~Aes_ctr_cipher() {
   close();
 }
 

storage/ndb/src/ndbapi/Ndb.cpp

@@ -440,7 +440,7 @@ int Ndb::computeHash(Uint32 *retval, const NdbDictionary::Table *table,
   while (true) {
     if (buf == nullptr) {
       bufLen = sumlen;
-      buf = malloc(bufLen);
+      buf = calloc(bufLen, 1);
       if (unlikely(buf == nullptr)) return 4000;
       malloced_buf = buf; /* Remember to free */
     }

storage/ndb/tools/NdbImportUtil.cpp

@@ -1332,7 +1332,7 @@ void NdbImportUtil::free_rows(RowList &src) {
 NdbImportUtil::Blob::Blob() {
   m_blobsize = 0;
   m_allocsize = 0;
-  m_data = new uchar[0];
+  m_data = new uchar[1];
 }
 
 NdbImportUtil::Blob::~Blob() { delete[] m_data; }

storage/perfschema/pfs_buffer_container.h

@@ -969,7 +969,7 @@ class PFS_buffer_scalable_iterator {
 template <class T>
 class PFS_buffer_processor {
  public:
-  virtual ~PFS_buffer_processor<T>() = default;
+  virtual ~PFS_buffer_processor() = default;
   virtual void operator()(T *element) = 0;
 };
 

storage/perfschema/pfs_name.h

@@ -45,9 +45,9 @@ class Field;
 template <int max_length>
 struct PFS_any_name {
  public:
-  PFS_any_name<max_length>() { m_length = 0; }
+  PFS_any_name() { m_length = 0; }
 
-  PFS_any_name<max_length>(const PFS_any_name<max_length> &other) {
+  PFS_any_name(const PFS_any_name<max_length> &other) {
     assert(other.m_length <= max_length);
 
     if (0 < other.m_length && other.m_length <= max_length) {

testclients/mysql_client_test.cc

@@ -484,8 +484,15 @@ static void mct_start_logging(const char *test_case_name) {
     return;
   }
 
+#if defined(__GNUC__) && (__GNUC__ >= 14)
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wformat-truncation"
+#endif
   snprintf(mct_log_file_path, FILE_PATH_SIZE, "%s/%s.out.log",
            (const char *)tmp_dir, (const char *)test_case_name);
+#if defined(__GNUC__) && (__GNUC__ >= 14)
+#pragma GCC diagnostic pop
+#endif
 
   mct_log_file =
       my_fopen(mct_log_file_path, O_WRONLY | MY_FOPEN_BINARY, MYF(MY_WME));

unittest/gunit/hypergraph_optimizer-t.cc

@@ -6508,7 +6508,14 @@ struct CountingReceiver {
     return false;
   }
 
+#if defined(__GNUC__) && (__GNUC__ >= 14)
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Warray-bounds"
+#endif
   size_t count(NodeMap map) const { return m_num_subplans[map]; }
+#if defined(__GNUC__) && (__GNUC__ >= 14)
+#pragma GCC diagnostic pop
+#endif
 
   const JoinHypergraph &m_graph;
   std::unique_ptr<size_t[]> m_num_subplans;