Addressing review comments

Author: aibek.bukabayev [email protected]

sql/conn_handler/connection_handler_impl.h

@@ -135,7 +135,7 @@ class Thread_pool_connection_handler : public Connection_handler {
 
   uint get_max_threads() const override { return threadpool_max_threads; }
 
-  void post_daemonize_init() override { start_timer_thread(); }
+  void post_daemonize_init() override { tp_start_timer_thread(); }
 };
 
 #endif  // CONNECTION_HANDLER_IMPL_INCLUDED

sql/mysqld.cc

@@ -8158,13 +8158,10 @@ int mysqld_main(int argc, char **argv)
   }
 #endif
 
-  if (Connection_handler_manager::thread_handling ==
-      Connection_handler_manager::SCHEDULER_THREAD_POOL) {
-    // If --thread-handling=pool-of-threads is specified,
-    // the timer thread should start only after the daemon process has begun,
-    // provided that --daemonize was also specified.
-    Connection_handler_manager::get_instance()->post_daemonize_init();
-  }
+  // Post daemonization operations performed
+  // such as initializing the timer_thread when using
+  // --thread-handling=pool-of-threads
+  Connection_handler_manager::get_instance()->post_daemonize_init();
 
 #ifndef _WIN32
   user_info = check_user(mysqld_user);

sql/threadpool.h

@@ -81,6 +81,6 @@ extern void tp_set_threadpool_size(uint val) noexcept;
 extern void tp_set_threadpool_stall_limit(uint val) noexcept;
 
 /* Function to start the timer thread */
-extern void start_timer_thread() noexcept;
+extern void tp_start_timer_thread() noexcept;
 
 #endif /* THREADPOOL_INCLUDED */

sql/threadpool_unix.cc

@@ -612,7 +612,7 @@ static void start_timer(pool_timer_t *timer) noexcept {
   DBUG_VOID_RETURN;
 }
 
-void start_timer_thread() noexcept {
+void tp_start_timer_thread() noexcept {
   pool_timer.tick_interval = threadpool_stall_limit;
   start_timer(&pool_timer);
 }