Skip to content

Commit f91140e

Browse files
arndbebiederm
authored andcommitted
soc: ti: fix wkup_m3_rproc_boot_thread return type
The wkup_m3_rproc_boot_thread() function uses a nonstandard prototype, which broke after Eric's recent cleanup: drivers/soc/ti/wkup_m3_ipc.c: In function 'wkup_m3_rproc_boot_thread': drivers/soc/ti/wkup_m3_ipc.c:429:16: error: 'return' with a value, in function returning void [-Werror=return-type] 429 | return 0; | ^ drivers/soc/ti/wkup_m3_ipc.c:416:13: note: declared here 416 | static void wkup_m3_rproc_boot_thread(struct wkup_m3_ipc *m3_ipc) | ^~~~~~~~~~~~~~~~~~~~~~~~~ Change it to the normal prototype as it should have been from the start. Fixes: 111e704 ("exit/kthread: Have kernel threads return instead of calling do_exit") Fixes: cdd5de5 ("soc: ti: Add wkup_m3_ipc driver") Signed-off-by: Arnd Bergmann <[email protected]> Link: https://lkml.kernel.org/r/[email protected] Acked-by: Santosh Shilimkar <[email protected]> Acked-by: Tony Lindgren <[email protected]> Signed-off-by: Eric W. Biederman <[email protected]>
1 parent 00b06da commit f91140e

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

drivers/soc/ti/wkup_m3_ipc.c

+3-2
Original file line numberDiff line numberDiff line change
@@ -413,8 +413,9 @@ void wkup_m3_ipc_put(struct wkup_m3_ipc *m3_ipc)
413413
}
414414
EXPORT_SYMBOL_GPL(wkup_m3_ipc_put);
415415

416-
static void wkup_m3_rproc_boot_thread(struct wkup_m3_ipc *m3_ipc)
416+
static int wkup_m3_rproc_boot_thread(void *arg)
417417
{
418+
struct wkup_m3_ipc *m3_ipc = arg;
418419
struct device *dev = m3_ipc->dev;
419420
int ret;
420421

@@ -500,7 +501,7 @@ static int wkup_m3_ipc_probe(struct platform_device *pdev)
500501
* can boot the wkup_m3 as soon as it's ready without holding
501502
* up kernel boot
502503
*/
503-
task = kthread_run((void *)wkup_m3_rproc_boot_thread, m3_ipc,
504+
task = kthread_run(wkup_m3_rproc_boot_thread, m3_ipc,
504505
"wkup_m3_rproc_loader");
505506

506507
if (IS_ERR(task)) {

0 commit comments

Comments
 (0)