Skip to content

pathing_manager set map callback should not dereference the value #45

@griswaldbrooks

Description

@griswaldbrooks

Need

In order to allow the unhappy path lambdas to have their natural return types
As a pathing manager
I want to pass in the assignment to the success branch rather than dereferencing.

Acceptance Criteria

Scenario: set map callback in pathing manager should set response in a lambda
GIVEN set map callback in pathing manager is running
WHEN the happy path succeeds
THEN the response message should be set in a lambda given to and_then
AND the unhappy path should have return paths that don't force a SetMap::Response when then don't need it.

Tasks

  • Refactor the below lines

Notes

pathing_manager set map callback should not dereference the expected
https://github.com/PickNikRobotics/ros_testing_templates/blob/ros2/functional_programming_tests/src/pathing_manager.cpp#L52-L57

This forces the or_else clauses to have a particular return type, which doesn't make sense in context.
References:

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions