Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgradeableMissingGap rule may create a lot of Fps #55

Open
jes16jupyter opened this issue Jun 8, 2024 · 0 comments
Open

upgradeableMissingGap rule may create a lot of Fps #55

jes16jupyter opened this issue Jun 8, 2024 · 0 comments

Comments

@jes16jupyter
Copy link

Hi, thanks for great work.

I noticed that the current Implementation of upgradeableMissingGap just uses /Upgradeable/gi to match.

This could produce a lot of False catches.

  1. _gap may already in the contract
  2. OZ 5.0 uses storage layout.

Recommendation:

  1. change regex to exclude _gap.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jes16jupyter