refactor: Remover configuração não utilizada em estratégias de overflow e coordenador NoOp

Author: CAFernandes

src/Http/Pool/Strategies/GracefulFallback.php

@@ -12,11 +12,6 @@
  */
 class GracefulFallback implements OverflowStrategy
 {
-    /**
-     * Configuration
-     */
-    private array $config;
-
     /**
      * Metrics
      */
@@ -29,9 +24,10 @@ class GracefulFallback implements OverflowStrategy
     /**
      * Constructor
      */
-    public function __construct(array $config)
+    public function __construct(array $config = [])
     {
-        $this->config = $config;
+        // Configuration not used in GracefulFallback - intentionally ignored
+        unset($config); // Suppress unused parameter warning
     }
 
     /**
@@ -111,12 +107,12 @@ private function createFallbackRequest(array $params): mixed
      */
     private function createFallbackResponse(array $params): mixed
     {
-        return Psr7Pool::borrowResponse(
+        return Psr7Pool::getResponse(
             $params[0] ?? 200,
             $params[1] ?? [],
             $params[2] ?? null,
             $params[3] ?? '1.1',
-            $params[4] ?? null
+            $params[4] ?? ''
         );
     }
 

src/Http/Pool/Strategies/SmartRecycling.php

@@ -9,11 +9,6 @@
  */
 class SmartRecycling implements OverflowStrategy
 {
-    /**
-     * Configuration
-     */
-    private array $config;
-
     /**
      * Recycling candidates
      */
@@ -37,9 +32,10 @@ class SmartRecycling implements OverflowStrategy
     /**
      * Constructor
      */
-    public function __construct(array $config)
+    public function __construct(array $config = [])
     {
-        $this->config = $config;
+        // Configuration not used in SmartRecycling - intentionally ignored
+        unset($config); // Suppress unused parameter warning
     }
 
     /**
@@ -329,14 +325,13 @@ private function getAverageObjectAge(): float
 
         $now = microtime(true);
         $totalAge = 0;
-        $count = 0;
+        $count = count($this->objectLifecycles);
 
         foreach ($this->objectLifecycles as $lifecycle) {
             $totalAge += $now - $lifecycle['created_at'];
-            $count++;
         }
 
-        return $count > 0 ? $totalAge / $count : 0.0;
+        return $totalAge / $count;
     }
 
     /**
@@ -379,4 +374,12 @@ public function cleanup(): void
             }
         }
     }
+
+    /**
+     * Get recycling candidates
+     */
+    public function getRecycleCandidates(): array
+    {
+        return $this->recycleCandidates;
+    }
 }

src/Middleware/RateLimiter.php

@@ -228,13 +228,13 @@ private function checkTokenBucket(string $key): bool
         $bucket['last_refill'] = $now;
 
         // Check if token available
-        if ($bucket['tokens'] < 1) {
+        if ((float) $bucket['tokens'] < 1) {
             $this->setInStorage($storageKey, $bucket);
             return false;
         }
 
         // Consume token
-        $bucket['tokens']--;
+        $bucket['tokens'] = (float) $bucket['tokens'] - 1;
         $this->setInStorage($storageKey, $bucket);
 
         return true;
@@ -365,7 +365,7 @@ private function getRemainingFixedWindow(string $key): int
 
         $count = $this->getFromStorage($storageKey, 0);
         $count = is_numeric($count) ? (int) $count : 0;
-        return max(0, $this->config['max_requests'] - $count);
+        return (int) max(0, $this->config['max_requests'] - $count);
     }
 
     /**
@@ -380,9 +380,9 @@ private function getRemainingSlidingWindow(string $key): int
         $history = $this->getFromStorage($storageKey, []);
         if (is_array($history)) {
             $history = array_filter($history, fn($timestamp) => $timestamp > $windowStart);
-            return max(0, $this->config['max_requests'] - count($history));
+            return (int) max(0, $this->config['max_requests'] - count($history));
         }
-        return $this->config['max_requests'];
+        return (int) $this->config['max_requests'];
     }
 
     /**
@@ -410,9 +410,9 @@ private function getRemainingLeakyBucket(string $key): int
 
         if (is_array($bucket) && isset($bucket['volume'])) {
             $volume = is_numeric($bucket['volume']) ? (float) $bucket['volume'] : 0;
-            return max(0, $this->config['max_requests'] - (int) ceil($volume));
+            return (int) max(0, $this->config['max_requests'] - (int) ceil($volume));
         }
-        return $this->config['max_requests'];
+        return (int) $this->config['max_requests'];
     }
 
     /**

src/Middleware/TrafficClassifier.php

@@ -193,7 +193,8 @@ private function normalizePriority(mixed $priority): int
             return max(0, min(100, $priority));
         }
 
-        return match (strtolower((string) $priority)) {
+        $priorityString = is_string($priority) ? $priority : (is_numeric($priority) ? (string) $priority : 'normal');
+        return match (strtolower($priorityString)) {
             'system' => self::PRIORITY_SYSTEM,
             'critical' => self::PRIORITY_CRITICAL,
             'high' => self::PRIORITY_HIGH,
@@ -301,7 +302,7 @@ private function matchesPathPattern(Request $request, string $pattern): bool
      */
     private function matchesHeader(Request $request, string $name, string $value): bool
     {
-        $headerValue = $request->getHeaders()->get($name);
+        $headerValue = $request->getHeadersObject()->get($name);
 
         if ($headerValue === null) {
             return false;

src/Performance/HighPerformanceMode.php

@@ -214,7 +214,6 @@ public static function enable(
         self::initializeMemoryManagement();
 
         if ($app !== null) {
-            self::$app = $app;
             self::initializeTrafficManagement($app);
             self::initializeProtection($app);
             self::initializeMonitoring($app);
@@ -340,7 +339,7 @@ function ($request, $response, $next) {
                     $requestId = uniqid('req_', true);
 
                 // Start monitoring
-                    self::$monitor->startRequest(
+                    self::$monitor?->startRequest(
                         $requestId,
                         [
                             'path' => $request->pathCallable,
@@ -353,20 +352,20 @@ function ($request, $response, $next) {
                         $result = $next($request, $response);
 
                         // End monitoring
-                        self::$monitor->endRequest($requestId, $response->getStatusCode());
+                        self::$monitor?->endRequest($requestId, $response->getStatusCode());
 
                         return $result;
                     } catch (\Throwable $e) {
                         // Record error
-                        self::$monitor->recordError(
+                        self::$monitor?->recordError(
                             'exception',
                             [
                                 'message' => $e->getMessage(),
                                 'code' => $e->getCode(),
                             ]
                         );
 
-                        self::$monitor->endRequest($requestId, 500);
+                        self::$monitor?->endRequest($requestId, 500);
 
                         throw $e;
                     }
@@ -375,10 +374,12 @@ function ($request, $response, $next) {
         }
 
         // Schedule periodic tasks
-        self::schedulePeriodicTask(
-            self::$currentConfig['monitoring']['export_interval'],
-            [self::$monitor, 'export']
-        );
+        if (self::$monitor) {
+            self::schedulePeriodicTask(
+                self::$currentConfig['monitoring']['export_interval'],
+                [self::$monitor, 'export']
+            );
+        }
     }
 
     /**

src/Pool/Distributed/Coordinators/NoOpCoordinator.php

@@ -12,17 +12,13 @@
  */
 class NoOpCoordinator implements CoordinatorInterface
 {
-    /**
-     * Configuration
-     */
-    private array $config;
-
     /**
      * Constructor
      */
-    public function __construct(array $config)
+    public function __construct(array $config = [])
     {
-        $this->config = $config;
+        // Configuration not used in NoOpCoordinator - intentionally ignored
+        unset($config); // Suppress unused parameter warning
     }
 
     /**
@@ -153,4 +149,3 @@ public function getGlobalPoolSize(): int
         return 0;
     }
 }
-