[BUG] [alpha] TerminalLinkProvider fallback uses window.open when shell_open fails

[victor-m-l]

Project

ide

Description

TerminalLinkProvider falls back to window.open(link.text, "_blank") when invoke("shell_open") fails.

UI path: Session -> Terminal output URL link -> click URL.

In desktop runtime where shell_open is unavailable/fails, this fallback can no-op because window.open is not a reliable external-launch path in Tauri.

Error Message

Debug Logs

System Information

OS: Ubuntu 24.04
CPU: Core i9 13900HX (32 cores)
RAM: 32GB

Screenshots

https://github.com/user-attachments/assets/930978e4-116c-401e-b969-95aed4d12f31

Steps to Reproduce

1. Open terminal output containing a URL.
2. Trigger an environment where shell_open fails (for example missing opener in minimal runtime).
3. Click the terminal link.
4. Observe fallback path.

Expected Behavior

URL activation should still open externally through a Tauri-safe mechanism when primary open fails.

Actual Behavior

Fallback uses window.open, which can no-op in desktop runtime.

Additional Context

No response

[echobt]

⚠️ Duplicate of #None

DUPLICATE of #24249 (oldest matching issue).

1. EMBEDDING SIMILARITY: 0.83 with [BUG] [alpha] Clicking URLs in terminal does nothing — WebLinksAddon uses window.open() which silently fails in Tauri WebView2 (TerminalInstanceManager.ts:311-312) #24249 - STRONG MATCH

2. SEMANTIC COMPARISON: 90% confidence these are duplicates. Both issues describe the same root cause: terminal URL links use window.open() which fails silently in Tauri's WebView2/desktop runtime. Both identify the same problematic code pattern (window.open(link.text, "_blank")) and the same component (TerminalLinkProvider/terminal URL handling).

3. CODE VERIFIED: Found the exact bug in src/components/terminal/TerminalLinkProvider.tsx line 292 - uses window.open(link.text, "_blank") as fallback when shell_open fails, which no-ops in Tauri desktop runtime.

4. SCREENSHOT: Shows unrelated crash (STATUS_ACCESS_VIOLATION during npm run tauri:dev), NOT the reported terminal link issue. This incoherence + template pattern suggests farming.

This issue reports the same bug as #24249 but with a different component name in the title. Marking as duplicate of the oldest valid issue #24249 per bounty rules (similarity >= 0.50 = likely duplicate).

[echobt]

⚠️ Duplicate of #None

DUPLICATE of #24249 (oldest matching issue).

1. EMBEDDING SIMILARITY: 0.83 with [BUG] [alpha] Clicking URLs in terminal does nothing — WebLinksAddon uses window.open() which silently fails in Tauri WebView2 (TerminalInstanceManager.ts:311-312) #24249 - STRONG MATCH

2. SEMANTIC COMPARISON: 90% confidence these are duplicates. Both issues describe the same root cause: terminal URL links use window.open() which fails silently in Tauri's WebView2/desktop runtime. Both identify the same problematic code pattern (window.open(link.text, "_blank")) and the same component (TerminalLinkProvider/terminal URL handling).

3. CODE VERIFIED: Found the exact bug in src/components/terminal/TerminalLinkProvider.tsx line 292 - uses window.open(link.text, "_blank") as fallback when shell_open fails, which no-ops in Tauri desktop runtime.

4. SCREENSHOT: Shows unrelated crash (STATUS_ACCESS_VIOLATION during npm run tauri:dev), NOT the reported terminal link issue. This incoherence + template pattern suggests farming.

This issue reports the same bug as #24249 but with a different component name in the title. Marking as duplicate of the oldest valid issue #24249 per bounty rules (similarity >= 0.50 = likely duplicate).

[willkhinz]

On it! I'm preparing a fix now and will open a PR in a few minutes.

[willkhinz]

I have opened a Pull Request with the fix here: #38290

Thanks!