[BUG] [v1.1.0] Auxiliary sidebar: onActiveViewChange passes view id when toggling off active tab

[tubel-hi]

Project

ide

Description

AuxiliarySidebarProps.onActiveViewChange is typed as (viewId: string | null) => void, implying callers can use null when there is no active view. Clicking the already-active mini–activity-bar item calls auxiliaryBar.toggle() but still runs props.onActiveViewChange?.(viewId) with the same viewId, so consumers never see null on that path.

Error Message

Debug Logs

System Information

OS: Ubuntu
Context: Bounty Challenge v1.1.0

Screenshots

8.webm

Steps to Reproduce

Open the auxiliary sidebar and select a view so its tab is active.
Click that same view’s icon again (toggle sidebar off).
Observe the argument passed to onActiveViewChange.

Expected Behavior

Callback receives null (or otherwise signals no active view) when the active tab is toggled off / sidebar hides that selection.

Actual Behavior

Callback always receives the clicked viewId, including after the toggle-off branch.

Additional Context

No response

[willkhinz]

/attempt #39590

[willkhinz]

/attempt #39590

[hinzwilliam52-ship-it]

/attempt #39590

[willkhinz]

/attempt #39590

[echobt]

✅ Validated

VALID BUG - Confirmed in source code

Component Location: src/components/workbench/AuxiliarySidebar.tsx

Bug Verification:
The bug is confirmed in the handleViewSelect function at lines 500-508:

const handleViewSelect = (viewId: string) => {
  if (auxiliaryBar.activeViewId() === viewId) {
    // Toggle visibility if clicking the active view
    auxiliaryBar.toggle();  // Sidebar is toggled OFF
  } else {
    auxiliaryBar.setActiveView(viewId);
  }
  props.onActiveViewChange?.(viewId);  // BUG: Always passes viewId, even when toggled off!
};

The Issue:

1. The onActiveViewChange callback is typed as (viewId: string | null) => void (line 54), implying null should be passed when there is no active view
2. When clicking an already-active view icon, auxiliaryBar.toggle() is called to hide the sidebar
3. However, props.onActiveViewChange?.(viewId) is called AFTER the toggle with the same viewId, so consumers never receive null when the sidebar is toggled off
4. This breaks the contract implied by the type signature - callers expect null when no view is active

Screenshot/Video: The video shows the Cortex IDE interface with the auxiliary sidebar on the right side. The user demonstrates clicking the "Outline" and "Chat" icons to toggle the sidebar, which matches the reproduction steps. The video is authentic and coherent with the issue.

Accessibility: The AuxiliarySidebar component is exported from src/components/workbench/index.ts and is part of the workbench layout system, making it accessible to users.

Conclusion: This is a real bug where the callback contract is violated - consumers cannot properly track when no view is active because they never receive null on the toggle-off path.