From 013d519462e946508e9f6b1fb7688a0a7fcaa1d0 Mon Sep 17 00:00:00 2001 From: bhers4 Date: Wed, 13 Aug 2025 12:29:54 -0700 Subject: [PATCH 1/5] Testing fusion engine client with bazel version upgraded from 4.2.2 to 6.5.0 --- .github/workflows/release_build.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/release_build.yml b/.github/workflows/release_build.yml index c1b3c528..26e36fdf 100644 --- a/.github/workflows/release_build.yml +++ b/.github/workflows/release_build.yml @@ -56,10 +56,10 @@ jobs: - uses: actions/checkout@v2 # Compile. - - name: Install Bazel 4.2.2 + - name: Install Bazel 6.5.0 uses: abhinavsingh/setup-bazel@v3 with: - version: 4.2.2 + version: 6.5.0 - name: Setup Environment (Linux) if: matrix.os == 'ubuntu-latest' From a95ff6736e230ae991925be6e72485614639f621 Mon Sep 17 00:00:00 2001 From: bhers Date: Tue, 19 Aug 2025 09:36:47 -0700 Subject: [PATCH 2/5] Added varying bazel versions to the github actions workflow --- .bazelversion | 1 + .github/workflows/release_build.yml | 15 +++++++++++++-- 2 files changed, 14 insertions(+), 2 deletions(-) create mode 100644 .bazelversion diff --git a/.bazelversion b/.bazelversion new file mode 100644 index 00000000..4be2c727 --- /dev/null +++ b/.bazelversion @@ -0,0 +1 @@ +6.5.0 \ No newline at end of file diff --git a/.github/workflows/release_build.yml b/.github/workflows/release_build.yml index 26e36fdf..bc9df2f8 100644 --- a/.github/workflows/release_build.yml +++ b/.github/workflows/release_build.yml @@ -43,27 +43,38 @@ jobs: strategy: matrix: include: + - os: ubuntu-latest + compiler: gcc + version: 10 + bazel: 4.2.2 + # Add entries for different Bazel versions - os: ubuntu-latest compiler: gcc version: 9 + bazel: 6.5.0 - os: ubuntu-latest compiler: gcc version: 10 + bazel: 6.5.0 - os: ubuntu-latest compiler: clang version: 14 + bazel: 6.5.0 steps: - uses: actions/checkout@v2 # Compile. - - name: Install Bazel 6.5.0 + - name: Install Bazel ${{ matrix.bazel }} uses: abhinavsingh/setup-bazel@v3 with: - version: 6.5.0 + version: ${{ matrix.bazel }} - name: Setup Environment (Linux) if: matrix.os == 'ubuntu-latest' run: | + # Set Bazel version override + echo "USE_BAZEL_VERSION=${{ matrix.bazel }}" >> $GITHUB_ENV + if [[ "${{ matrix.compiler }}" == "gcc" ]]; then sudo apt install gcc-${{ matrix.version }} g++-${{ matrix.version }} sudo update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-${{ matrix.version }} 100 \ From aa533c3426adb5239cf5c0a63259aceb46db69d4 Mon Sep 17 00:00:00 2001 From: bhers Date: Tue, 19 Aug 2025 10:37:04 -0700 Subject: [PATCH 3/5] Updated README and comments in the Github actions to explain why I use the USE_BAZEL_VERSION environment variable --- .github/workflows/release_build.yml | 9 ++++++--- README.md | 2 +- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/.github/workflows/release_build.yml b/.github/workflows/release_build.yml index bc9df2f8..851728c8 100644 --- a/.github/workflows/release_build.yml +++ b/.github/workflows/release_build.yml @@ -43,11 +43,12 @@ jobs: strategy: matrix: include: + # Do a singular build for Bazel 4.2.2 to test Bazel 4.2.2. - os: ubuntu-latest compiler: gcc version: 10 bazel: 4.2.2 - # Add entries for different Bazel versions + # Run Bazel 6.5.0 on all compilers versions. - os: ubuntu-latest compiler: gcc version: 9 @@ -72,9 +73,11 @@ jobs: - name: Setup Environment (Linux) if: matrix.os == 'ubuntu-latest' run: | - # Set Bazel version override + # Just for Github action builds set USE_BAZEL_VERSION to override the + # .bazelversion file so we can test different Bazel versions even though + # the recommended Bazel version will be in the .bazelversion file. echo "USE_BAZEL_VERSION=${{ matrix.bazel }}" >> $GITHUB_ENV - + if [[ "${{ matrix.compiler }}" == "gcc" ]]; then sudo apt install gcc-${{ matrix.version }} g++-${{ matrix.version }} sudo update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-${{ matrix.version }} 100 \ diff --git a/README.md b/README.md index 31ad173a..e13c0599 100644 --- a/README.md +++ b/README.md @@ -46,7 +46,7 @@ One FusionEngine or a Point One device (Atlas, Quectel LG69T, etc.), please cont #### C++ Support - C++11 or later -- CMake 3.x or Bazel 3.x +- CMake 3.x or Bazel 4.x-6.x (tested with Bazel versions 4.2.2-6.5.0, Bazel 8+ not currently supported) - GCC, Clang, or Microsoft Visual Studio #### Python Support From 9450cb0e742f939e08f70f0f3c70b38665874e46 Mon Sep 17 00:00:00 2001 From: bhers Date: Tue, 19 Aug 2025 10:51:39 -0700 Subject: [PATCH 4/5] Introducing gcc 11 to compiler matrix --- .github/workflows/release_build.yml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/release_build.yml b/.github/workflows/release_build.yml index 851728c8..cc9ee916 100644 --- a/.github/workflows/release_build.yml +++ b/.github/workflows/release_build.yml @@ -46,7 +46,7 @@ jobs: # Do a singular build for Bazel 4.2.2 to test Bazel 4.2.2. - os: ubuntu-latest compiler: gcc - version: 10 + version: 11 bazel: 4.2.2 # Run Bazel 6.5.0 on all compilers versions. - os: ubuntu-latest @@ -57,6 +57,10 @@ jobs: compiler: gcc version: 10 bazel: 6.5.0 + - os: ubuntu-latest + compiler: gcc + version: 11 + bazel: 6.5.0 - os: ubuntu-latest compiler: clang version: 14 From 760d6746bfe1493c374c5d808255338830e0cba8 Mon Sep 17 00:00:00 2001 From: bhers Date: Tue, 19 Aug 2025 14:07:32 -0700 Subject: [PATCH 5/5] Cleaned up README comment --- README.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index e13c0599..c08bccc2 100644 --- a/README.md +++ b/README.md @@ -46,7 +46,8 @@ One FusionEngine or a Point One device (Atlas, Quectel LG69T, etc.), please cont #### C++ Support - C++11 or later -- CMake 3.x or Bazel 4.x-6.x (tested with Bazel versions 4.2.2-6.5.0, Bazel 8+ not currently supported) +- CMake 3.x or Bazel 4.x-6.x + - Tested with Bazel versions 4.2.2-6.5.0, Bazel 8+ not currently supported - GCC, Clang, or Microsoft Visual Studio #### Python Support