Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for 1.21.4 on Paper #483

Open
wants to merge 2 commits into
base: ver/6.6.0
Choose a base branch
from
Open

Add support for 1.21.4 on Paper #483

wants to merge 2 commits into from

Conversation

OakLoaf
Copy link
Contributor

@OakLoaf OakLoaf commented Dec 12, 2024

As the NMS world generation code has not change since 1.21.3 I have simply added a version check, this jar should work for both 1.21.3 and 1.21.4

@solonovamax solonovamax mentioned this pull request Jan 17, 2025
Open
@solonovamax solonovamax linked an issue Jan 17, 2025 that may be closed by this pull request
Update Terra to 1.21.4 #486
Open
@Xpomodz
Copy link

Xpomodz commented Jan 26, 2025

How do we update this im getting this sisue?
image

@solonovamax
Copy link
Member

How do we update this im getting this sisue?

install git and make sure it's in your PATH

@solonovamax solonovamax changed the title Added support for 1.21.4 Add support for 1.21.4 on Paper Jan 27, 2025
solonovamax
solonovamax approved these changes Jan 27, 2025
View reviewed changes
Copy link
Member

@solonovamax solonovamax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kai-Denzel-Jane
Copy link

How do we update this im getting this sisue? image

I'm having the same issue I have git installed on windows and its in my PATH but it still results in this same exit code

@TobyWarren

This comment was marked as off-topic.

Sign in to view
@Kai-Denzel-Jane
Copy link

How do we update this im getting this sisue? image

I'm having the same issue I have git installed on windows and its in my PATH but it still results in this same exit code

Not sure why that is happening, but if you want a compiled version, grab it off my github, Oak is probably already working to fix issues, don't need to comment the same issue multiple times.

Alright thanks

@solonovamax
Copy link
Member

Not sure why that is happening, but if you want a compiled version, grab it off my github, Oak is probably already working to fix issues, don't need to comment the same issue multiple times.

this is not an issue with the PR, this is an issue with the user's compile environment

@OakLoaf
Copy link
Contributor Author

OakLoaf commented Feb 5, 2025 •
edited
Loading

Not sure why that is happening, but if you want a compiled version, grab it off my github, Oak is probably already working to fix issues, don't need to comment the same issue multiple times.

I've published a compiled release of the latest commit, it appears as though the release being shared above is not from this PR, which is therefore not particularly helpful to this PR.
https://github.com/OakLoaf/Terra/releases/tag/6.6.0%2F1.21.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@solonovamax solonovamax solonovamax approved these changes

@dfsek dfsek Awaiting requested review from dfsek dfsek is a code owner

@duplexsystem duplexsystem Awaiting requested review from duplexsystem duplexsystem is a code owner

@justaureus justaureus Awaiting requested review from justaureus justaureus is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Terra to 1.21.4
5 participants
@OakLoaf @Xpomodz @solonovamax @Kai-Denzel-Jane @TobyWarren