fix(canvas): align startup and artifact source contracts

Generated-By: PostHog Code
Task-Id: 45da9f78-5b15-4cfe-a8a5-9afcbd6b4755

Author: k11kirky

packages/api-client/src/task-normalization.ts

@@ -109,7 +109,11 @@ function normalizeTaskRunArtifact(
     ...(artifact.id === undefined ? {} : { id: artifact.id }),
     name: artifact.name,
     type: normalizeArtifactType(artifact.type),
-    ...(artifact.source === undefined ? {} : { source: artifact.source }),
+    ...(artifact.source === "agent_output" ||
+    artifact.source === "user_attachment" ||
+    artifact.source === "posthog_code_skill"
+      ? { source: artifact.source }
+      : {}),
     ...(artifact.size === undefined ? {} : { size: artifact.size }),
     ...(artifact.content_type === undefined
       ? {}

packages/shared/src/domain-types.ts

@@ -597,7 +597,8 @@ export interface PriorityJudgmentContent {
 }
 
 /** Artefact with `type: "actionability_judgment"` — actionability assessment from the agentic report. */
-export interface ActionabilityJudgmentArtefact extends SignalReportArtefactBase {
+export interface ActionabilityJudgmentArtefact
+  extends SignalReportArtefactBase {
   type: "actionability_judgment";
   content: ActionabilityJudgmentContent;
 }

packages/ui/src/shell/startupLocation.test.ts

@@ -8,28 +8,31 @@ describe("startup location", () => {
   it("restores the exact last location", async () => {
     vi.spyOn(stateStorage, "getItem").mockResolvedValue("/code");
     const client = {
-      getDesktopFileSystemChannels: vi.fn(),
-      createDesktopFileSystemChannel: vi.fn(),
+      getTaskChannels: vi.fn(),
     };
 
     await expect(resolveStartupLocation("project", client)).resolves.toBe(
       "/code",
     );
-    expect(client.getDesktopFileSystemChannels).not.toHaveBeenCalled();
+    expect(client.getTaskChannels).not.toHaveBeenCalled();
   });
 
   it("opens a new task in me when there is no saved location", async () => {
     vi.spyOn(stateStorage, "getItem").mockResolvedValue(null);
     const client = {
-      getDesktopFileSystemChannels: vi
-        .fn()
-        .mockResolvedValue([{ id: "me-id", path: "me", type: "folder" }]),
-      createDesktopFileSystemChannel: vi.fn(),
+      getTaskChannels: vi.fn().mockResolvedValue([
+        {
+          id: "me-id",
+          name: "me",
+          channel_type: "personal",
+          starred: false,
+        },
+      ]),
     };
 
     await expect(resolveStartupLocation("project", client)).resolves.toBe(
       "/website/me-id/new",
     );
-    expect(client.createDesktopFileSystemChannel).not.toHaveBeenCalled();
+    expect(client.getTaskChannels).toHaveBeenCalledOnce();
   });
 });

packages/ui/src/shell/startupLocation.ts

@@ -1,18 +1,20 @@
-import {
-  ensurePersonalChannelFromClient,
-  type PersonalChannelClient,
-} from "@posthog/ui/features/canvas/ensurePersonalChannel";
+import type { PostHogAPIClient } from "@posthog/api-client/posthog-client";
 import { stateStorage } from "@posthog/ui/shell/rendererStorage";
 
+type StartupLocationClient = Pick<PostHogAPIClient, "getTaskChannels">;
+
 const storageKey = (identity: string): string => `startup-location:${identity}`;
 
 export async function resolveStartupLocation(
   identity: string,
-  client: PersonalChannelClient,
+  client: StartupLocationClient,
 ): Promise<string> {
   const saved = await stateStorage.getItem(storageKey(identity));
   if (saved) return saved;
-  const personal = await ensurePersonalChannelFromClient(client);
+  const personal = (await client.getTaskChannels()).find(
+    (channel) => channel.channel_type === "personal",
+  );
+  if (!personal) throw new Error("Personal channel was not provisioned");
   return `/website/${personal.id}/new`;
 }