refactor: sessions (#248)

Session store and all related types were an absolute mess. I refactored it so we now only use ACP types directly, so I can actually work on improving session rendering. Also updated our knip config.

Author: jonathanlab

CLAUDE.md

@@ -42,6 +42,16 @@
 - TypeScript strict mode enabled
 - Tailwind CSS classes should be sorted (biome `useSortedClasses` rule)
 
+### Avoid Barrel Files
+
+Barrel files:
+- Break tree-shaking
+- Create circular dependency risks  
+- Hide the true source of imports
+- Make refactoring harder
+
+Import directly from source files instead.
+
 ## Architecture
 
 ### Electron App (apps/array)

apps/array/knip.json

@@ -20,7 +20,6 @@
     "build-icons": "bash scripts/generate-icns.sh",
     "typecheck": "tsc -p tsconfig.node.json --noEmit && tsc -p tsconfig.web.json --noEmit",
     "generate-client": "tsx scripts/update-openapi-client.ts",
-    "knip": "knip",
     "test": "vitest run",
     "postinstall": "cd ../.. && npx @electron/rebuild -f -m node_modules/node-pty || true"
   },
@@ -54,7 +53,6 @@
     "electron": "^30.0.0",
     "husky": "^9.1.7",
     "jsdom": "^26.0.0",
-    "knip": "^5.66.3",
     "lint-staged": "^15.5.2",
     "postcss": "^8.4.33",
     "tailwindcss": "^3.4.1",
@@ -67,6 +65,7 @@
     "yaml": "^2.8.1"
   },
   "dependencies": {
+    "@agentclientprotocol/sdk": "^0.9.0",
     "@ai-sdk/openai": "^2.0.52",
     "@codemirror/lang-angular": "^0.1.4",
     "@codemirror/lang-cpp": "^6.0.3",
@@ -126,6 +125,7 @@
     "electron-store": "^11.0.0",
     "file-icon": "^6.0.0",
     "idb-keyval": "^6.2.2",
+    "immer": "^11.0.1",
     "is-glob": "^4.0.3",
     "micromatch": "^4.0.5",
     "node-addon-api": "^8.5.0",

apps/array/package.json

@@ -1,7 +1,7 @@
-import type { StoredLogEntry } from "@features/sessions/utils/parseSessionLogs";
 import type { AgentEvent } from "@posthog/agent";
 import { logger } from "@renderer/lib/logger";
 import type { Task, TaskRun } from "@shared/types";
+import type { StoredLogEntry } from "@shared/types/session-events";
 import { buildApiFetcher } from "./fetcher";
 import { createApiClient, type Schemas } from "./generated";
 

apps/array/src/api/posthogClient.ts

@@ -18,24 +18,18 @@ import {
   type IpcMainInvokeEvent,
   ipcMain,
 } from "electron";
+import type { AcpMessage } from "../../shared/types/session-events";
 import { logger } from "../lib/logger";
 
 const log = logger.scope("session-manager");
 
-type MessageCallback = (
-  message: unknown,
-  direction: "client" | "agent",
-) => void;
-type MessageDirection = "client" | "agent";
+type MessageCallback = (message: unknown) => void;
 
 class NdJsonTap {
   private decoder = new TextDecoder();
   private buffer = "";
 
-  constructor(
-    private onMessage: MessageCallback,
-    private direction: MessageDirection,
-  ) {}
+  constructor(private onMessage: MessageCallback) {}
 
   process(chunk: Uint8Array): void {
     this.buffer += this.decoder.decode(chunk, { stream: true });
@@ -45,7 +39,7 @@ class NdJsonTap {
     for (const line of lines) {
       if (!line.trim()) continue;
       try {
-        this.onMessage(JSON.parse(line), this.direction);
+        this.onMessage(JSON.parse(line));
       } catch {
         // Not valid JSON, skip
       }
@@ -56,10 +50,9 @@ class NdJsonTap {
 function createTappedReadableStream(
   underlying: ReadableStream<Uint8Array>,
   onMessage: MessageCallback,
-  direction: MessageDirection,
 ): ReadableStream<Uint8Array> {
   const reader = underlying.getReader();
-  const tap = new NdJsonTap(onMessage, direction);
+  const tap = new NdJsonTap(onMessage);
 
   return new ReadableStream<Uint8Array>({
     async pull(controller) {
@@ -77,9 +70,8 @@ function createTappedReadableStream(
 function createTappedWritableStream(
   underlying: WritableStream<Uint8Array>,
   onMessage: MessageCallback,
-  direction: MessageDirection,
 ): WritableStream<Uint8Array> {
-  const tap = new NdJsonTap(onMessage, direction);
+  const tap = new NdJsonTap(onMessage);
 
   return new WritableStream<Uint8Array>({
     async write(chunk) {
@@ -471,30 +463,31 @@ export class SessionManager {
       }
     };
 
-    // Emit all raw ACP messages (bidirectional) to the renderer
-    const onAcpMessage = (message: unknown, direction: "client" | "agent") => {
-      emitToRenderer({
+    // Emit all raw ACP messages to the renderer
+    const onAcpMessage = (message: unknown) => {
+      const acpMessage: AcpMessage = {
         type: "acp_message",
-        direction,
         ts: Date.now(),
-        message,
-      });
+        message: message as AcpMessage["message"],
+      };
+      emitToRenderer(acpMessage);
     };
 
-    // Tap both streams to capture all messages bidirectionally
+    // Tap both streams to capture all messages
     const tappedReadable = createTappedReadableStream(
       clientStreams.readable as ReadableStream<Uint8Array>,
       onAcpMessage,
-      "agent",
     );
 
     const tappedWritable = createTappedWritableStream(
       clientStreams.writable as WritableStream<Uint8Array>,
       onAcpMessage,
-      "client",
     );
 
     // Create Client implementation that forwards to renderer
+    // Note: sessionUpdate is NOT implemented here because session/update
+    // notifications are already captured by the stream tap and forwarded
+    // as acp_message events. This avoids duplicate events.
     const client: Client = {
       async requestPermission(
         params: RequestPermissionRequest,
@@ -511,12 +504,9 @@ export class SessionManager {
         };
       },
 
-      async sessionUpdate(params: SessionNotification): Promise<void> {
-        emitToRenderer({
-          type: "session_update",
-          ts: Date.now(),
-          notification: params,
-        });
+      async sessionUpdate(_params: SessionNotification): Promise<void> {
+        // No-op: session/update notifications are captured by the stream tap
+        // and forwarded as acp_message events to avoid duplication
       },
     };