Preserve pin state when archive lookup fails

Generated-By: PostHog Code
Task-Id: 4829266a-889b-49eb-bacd-4c1426b27b2b

Author: richardsolomou

packages/core/src/archive/archiveOrchestration.test.ts

@@ -123,7 +123,20 @@ describe("archiveTask", () => {
     expect(harness.deps.archive).toHaveBeenCalledWith(TASK_ID);
   });
 
+  it("preserves pin state when reading task pins and archiving fail", async () => {
+    harness.deps.getPinnedTaskIds = vi
+      .fn()
+      .mockRejectedValue(new Error("pins unavailable"));
+    harness.deps.archive = vi.fn().mockRejectedValue(new Error("boom"));
+
+    await expect(archiveTask(TASK_ID, harness.deps)).rejects.toThrow("boom");
+
+    expect(harness.deps.unpin).not.toHaveBeenCalled();
+    expect(harness.deps.togglePin).not.toHaveBeenCalled();
+  });
+
   it("archives when unpinning fails", async () => {
+    harness.deps.getPinnedTaskIds = vi.fn().mockResolvedValue([TASK_ID]);
     harness.deps.unpin = vi
       .fn()
       .mockRejectedValue(new Error("pins unavailable"));

packages/core/src/archive/archiveOrchestration.ts

@@ -67,7 +67,7 @@ export async function archiveTask(
   }
 
   const optimistic = options?.optimistic ?? true;
-  let wasPinned = false;
+  let wasPinned: boolean | undefined;
   try {
     wasPinned = (await deps.getPinnedTaskIds()).includes(taskId);
   } catch (error) {
@@ -80,10 +80,12 @@ export async function archiveTask(
 
   const commandCenterSnapshot = deps.snapshotCommandCenter(taskId);
 
-  try {
-    await deps.unpin(taskId);
-  } catch (error) {
-    deps.logError("Failed to unpin task while archiving", error);
+  if (wasPinned) {
+    try {
+      await deps.unpin(taskId);
+    } catch (error) {
+      deps.logError("Failed to unpin task while archiving", error);
+    }
   }
   deps.removeFromCommandCenter(taskId);