Skip to content
This repository was archived by the owner on Aug 6, 2026. It is now read-only.

Commit 9926f2e

Browse files
authored
refactor(canvas): drop comments from the Activity bell popover
Generated-By: PostHog Code Task-Id: f89ba875-c0c8-4a08-b088-67b2a900e66d
1 parent 87d00c3 commit 9926f2e

2 files changed

Lines changed: 0 additions & 9 deletions

File tree

packages/ui/src/features/canvas/components/ChannelNav.test.tsx

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -108,14 +108,11 @@ describe("ChannelNav", () => {
108108
rerender(<ChannelNav />);
109109
await user.unhover(bell());
110110

111-
// Opening a notification from the Activity page navigates to its task: the
112-
// card must not come along for the ride.
113111
mocks.view = { type: "task-detail" };
114112
rerender(<ChannelNav />);
115113
await new Promise((resolve) => setTimeout(resolve, 400));
116114
expect(screen.queryByText("Recent activity card")).not.toBeInTheDocument();
117115

118-
// ...and hover must still work there.
119116
await user.hover(bell());
120117
expect(
121118
await screen.findByText("Recent activity card", {}, { timeout: 1_000 }),

packages/ui/src/features/canvas/components/ChannelNav.tsx

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -138,12 +138,6 @@ function NavButton({
138138
);
139139
}
140140

141-
// Only mounted off the Activity page, so the card's open state is born fresh on
142-
// every visit. That matters because refusing an open is not free: quill's
143-
// trigger applies it internally before we see it, so a `false` we hand back
144-
// leaves the trigger stuck in its pressed state with hover-open dead until it
145-
// remounts. Nothing here refuses one — the click prevents the trigger's own
146-
// open, and the Activity page renders the bell without a popover at all.
147141
function ActivityHoverPopover({ trigger }: { trigger: ReactElement }) {
148142
const [open, setOpen] = useState(false);
149143

0 commit comments

Comments
 (0)