fix(archive): tolerate task pin sync failures (#3980)

Author: richardsolomou

packages/core/src/archive/archiveOrchestration.test.ts

@@ -113,6 +113,39 @@ describe("archiveTask", () => {
     expect(harness.deps.togglePin).toHaveBeenCalledWith(TASK_ID);
   });
 
+  it("archives when reading task pins fails", async () => {
+    harness.deps.getPinnedTaskIds = vi
+      .fn()
+      .mockRejectedValue(new Error("pins unavailable"));
+
+    await archiveTask(TASK_ID, harness.deps);
+
+    expect(harness.deps.archive).toHaveBeenCalledWith(TASK_ID);
+  });
+
+  it("preserves pin state when reading task pins and archiving fail", async () => {
+    harness.deps.getPinnedTaskIds = vi
+      .fn()
+      .mockRejectedValue(new Error("pins unavailable"));
+    harness.deps.archive = vi.fn().mockRejectedValue(new Error("boom"));
+
+    await expect(archiveTask(TASK_ID, harness.deps)).rejects.toThrow("boom");
+
+    expect(harness.deps.unpin).not.toHaveBeenCalled();
+    expect(harness.deps.togglePin).not.toHaveBeenCalled();
+  });
+
+  it("archives when unpinning fails", async () => {
+    harness.deps.getPinnedTaskIds = vi.fn().mockResolvedValue([TASK_ID]);
+    harness.deps.unpin = vi
+      .fn()
+      .mockRejectedValue(new Error("pins unavailable"));
+
+    await archiveTask(TASK_ID, harness.deps);
+
+    expect(harness.deps.archive).toHaveBeenCalledWith(TASK_ID);
+  });
+
   it("destroys terminals only after the archive succeeds", async () => {
     let clearedWhenArchiveCalled = true;
     harness.deps.archive = vi.fn().mockImplementation(async () => {

packages/core/src/archive/archiveOrchestration.ts

@@ -67,16 +67,26 @@ export async function archiveTask(
   }
 
   const optimistic = options?.optimistic ?? true;
-  const pinnedTaskIds = await deps.getPinnedTaskIds();
-  const wasPinned = pinnedTaskIds.includes(taskId);
+  let wasPinned: boolean | undefined;
+  try {
+    wasPinned = (await deps.getPinnedTaskIds()).includes(taskId);
+  } catch (error) {
+    deps.logError("Failed to read task pin state while archiving", error);
+  }
 
   if (!options?.skipNavigate) {
     deps.navigateAwayFromTaskIfActive(taskId);
   }
 
   const commandCenterSnapshot = deps.snapshotCommandCenter(taskId);
 
-  await deps.unpin(taskId);
+  if (wasPinned) {
+    try {
+      await deps.unpin(taskId);
+    } catch (error) {
+      deps.logError("Failed to unpin task while archiving", error);
+    }
+  }
   deps.removeFromCommandCenter(taskId);
 
   await deps.cache.cancelPathFilter();
@@ -118,7 +128,14 @@ export async function archiveTask(
     deps.cache.setArchivedTaskIds((old) => removeArchivedTaskId(old, taskId));
     deps.cache.setArchiveList((old) => removeArchivedTask(old, taskId));
     if (wasPinned) {
-      await deps.togglePin(taskId);
+      try {
+        await deps.togglePin(taskId);
+      } catch (pinError) {
+        deps.logError(
+          "Failed to restore task pin after archive failure",
+          pinError,
+        );
+      }
     }
     if (commandCenterSnapshot.index !== -1) {
       deps.restoreCommandCenter(taskId, commandCenterSnapshot);