Skip to content

Update deprecated API method in docs #2230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2025
Merged

Update deprecated API method in docs #2230

merged 1 commit into from
Jul 1, 2025

Conversation

924312
Copy link
Contributor

@924312 924312 commented May 27, 2025

PR Summary

Not super familiar with Neovim but this is deprecated

vim.api.nvim_buf_set_option(bufnr, 'omnifunc', 'v:lua.vim.lsp.omnifunc')

and I believe this is the fix

vim.api.nvim_set_option_value("omnifunc", "v:lua.vim.lsp.omnifunc", { buf = bufnr })

PR Context

@924312 924312 requested a review from a team as a code owner May 27, 2025 07:08
andyleejordan
andyleejordan approved these changes Jun 18, 2025
View reviewed changes
Copy link
Member

@andyleejordan andyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY

@andyleejordan andyleejordan changed the title Update getting_started.md - replace deprecated API method Update deprecated API method in docs Jun 18, 2025
@andyleejordan andyleejordan enabled auto-merge (squash) June 18, 2025 03:49
@andyleejordan andyleejordan disabled auto-merge July 1, 2025 23:34
@andyleejordan andyleejordan merged commit d1223f7 into PowerShell:main Jul 1, 2025
6 checks passed
@andyleejordan andyleejordan added the Issue-Enhancement A feature request (enhancement). label Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyleejordan andyleejordan andyleejordan approved these changes

Assignees
No one assigned
Labels
Issue-Enhancement A feature request (enhancement).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@924312 @andyleejordan