Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align groups of assignments (=) #1385

Closed
hanpq opened this issue Jun 26, 2018 · 4 comments
Closed

Align groups of assignments (=) #1385

hanpq opened this issue Jun 26, 2018 · 4 comments
Labels
Area-Code Formatting Issue-Enhancement A feature request (enhancement). Up for Grabs Will shepherd PRs.

Comments

@hanpq
Copy link

hanpq commented Jun 26, 2018

I would love to see an option to allow alignment of assignmentgroups. Its easiest to show what I mean with an example. (Github wouldn't allow me to format the code manually and trimmed the whitespaces automatically so I had to attach a printscreen)

bild

So that '=' are aligned in columns within a group of assignments. A group could be interpreted as delimitered with a blank line.

I can see that not everyone would like this so this feature should probably be activated by an powershell.codeformating -setting.

@rjmholt rjmholt added Issue-Enhancement A feature request (enhancement). Up for Grabs Will shepherd PRs. Area-Code Formatting labels Jun 26, 2018
@rjmholt
Copy link
Contributor

rjmholt commented Jun 26, 2018

Formatting is actually provided by PSScriptAnalyzer's Invoke-Formatter command. We hook into it in EditorServices here.

I think the best thing to do is to open a new issue in PSScriptAnalyzer. Then we'll have a little bit of integration work to do but it should be pretty straightforward.

@hanpq
Copy link
Author

hanpq commented Jun 27, 2018

Ah, I see! I've made another feature request in PSScriptAnalyzer here: PowerShell/PSScriptAnalyzer#1029

Should I leave this feature request open since you said it might need integration work later on if the feature is implemented in PSScriptAnalyzer?

Thanks!

@rjmholt
Copy link
Contributor

rjmholt commented Jun 27, 2018

Awesome! Yeah I think we should leave the issue open here both to track the work to integrate and also for anyone else who is looking for this feature.

@TylerLeonhardt
Copy link
Member

Let's actually close this issue here for now until it's implemented in PSSA since there's (currently) no action item on the extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Code Formatting Issue-Enhancement A feature request (enhancement). Up for Grabs Will shepherd PRs.
Projects
None yet
Development

No branches or pull requests

3 participants