Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review: 1.90.0 VSCode Native PowerShell IntelliSense Issues #5000

Open
2 of 6 tasks
JustinGrote opened this issue Jun 6, 2024 · 5 comments
Open
2 of 6 tasks

Review: 1.90.0 VSCode Native PowerShell IntelliSense Issues #5000

JustinGrote opened this issue Jun 6, 2024 · 5 comments
Labels
Issue-Enhancement A feature request (enhancement).

Comments

@JustinGrote
Copy link
Collaborator

JustinGrote commented Jun 6, 2024

Prerequisites

  • I have written a descriptive issue title.
  • I have searched all issues to ensure it has not already been reported.

Summary

1.90 has some new preview PowerShell Intellisense
https://code.visualstudio.com/updates/v1_90#_vs-codenative-intellisense-for-powershell

image

Should probably make sure there aren't any conflicts with this extension. I'm sure they tested, but still.

This is an overall tracker to open issues over in the VSCode repository if they don't get fixed or aren't being tracked otherwise, so we will need to mitigate or provide warnings in our extension if we detect it is enabled.

VSCode Tracking Issue

Observed Issues

  • Font Settings dont work
  • Hijacks Tab and Ctrl-Enter PSReadline, doesn't complete in a manner expected by PS
  • Repeated Entries observed (e.g. same function listed 3 times)
  • Not all completions showing. For instance parameter completion above only shows P parameters even tho I didn't specify that far in the completion.
@JustinGrote JustinGrote added Issue-Enhancement A feature request (enhancement). Needs: Triage Maintainer attention needed! labels Jun 6, 2024
@JustinGrote
Copy link
Collaborator Author

@andyleejordan are you in any coordination with the vscode team on this?

@JustinGrote JustinGrote changed the title Review: Ensure 1.90.0 VSCode Native PowerShell IntelliSense doesn't conflict. Review: 1.90.0 VSCode Native PowerShell IntelliSense Issues Jun 6, 2024
@Tyriar
Copy link
Contributor

Tyriar commented Jun 7, 2024

@JustinGrote we sync up every month. I don't directly test the pwsh extension and I'm not aware of any conflicts. The 3 latter issues you mention seem like they should be tracked in new VS Code issues.

Hijacks Tab and Ctrl-Enter PSReadline, doesn't complete in a manner expected by PS

If you mean it's hijacked when the suggest widget is visible, this is by design. Everything except for ctrl+space should work the same as before when it's hidden (via escape, configure settings to change when it's shown).

@JustinGrote
Copy link
Collaborator Author

Sounds great! This was mostly to verify as a sanity check, and as mentioned, I'll open issues as-found once I have more time to evaluate.

@Tyriar
Copy link
Contributor

Tyriar commented Jul 23, 2024

Lots of improvements coming in the next release, summary here: microsoft/vscode#223130

@SydneyhSmith
Copy link
Collaborator

SydneyhSmith commented Jul 25, 2024

Thanks @Tyriar looks great, Andy's excited to go test.

@SydneyhSmith SydneyhSmith removed the Needs: Triage Maintainer attention needed! label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Enhancement A feature request (enhancement).
Projects
None yet
Development

No branches or pull requests

3 participants