Hello @jexamd ,

Could you please provide us with more info ?
We need more details to understand how we can reproduce your issue:

• host
• server setup and configuration
• PrestaShop version (source)
• debug mode report
• PHP error logs
• apache error log
• Javascript console log
• screenshots
• ...

You don't know how to get this information? Please read the following article: How to create a bug report.

Thank you

Hello @jexamd ,

Could you explicit the steps to reproduce ?

Thanks

The code in question handles the price indexing of products in a PrestaShop module called ps_facetedsearch. The indexing process occurs in a do-while loop, iterating over a set of products and updating a cursor ($cursor) to move between product IDs.

How the Loop Works

• $cursor: Represents the current product ID being processed.
• $nbProducts: Represents the total number of products to be indexed.
• $length: Defines how many products are processed in each iteration (e.g., 100 products at a time).

The loop continues as long as:

• $cursor < $nbProducts
• Memory usage does not exceed the allowed limit
• Execution time does not exceed the maximum allowed time ($maxExecutionTime)

The Problem

The issue arises when the value of $cursor exceeds $nbProducts, causing $cursor < $nbProducts to become false and terminating the loop prematurely. This behavior does not account for:

1. Gaps in the ID sequence

   • If some products have been deleted, product IDs might not be consecutive (e.g., IDs: 1, 2, 5, 10).
   • $cursor could exceed $nbProducts before processing all actual products.

2. Maximum ID greater than $nbProducts

   • If the highest product ID in the database is greater than $nbProducts, the loop may stop before processing all products.

Result

• The loop performs only one iteration at a time (or stops entirely) when $cursor exceeds $nbProducts, leading to incomplete and inefficient indexing.

Example

Given Products:

Product IDs in the database: 1, 2, 3, 5, 10
$nbProducts = 4 (total number of products to be indexed)
$cursor starts at 0 and increments by 100 per iteration.

Current Behavior:

1. First iteration: $cursor = 100 (processes products with IDs from 1 to 100).
2. Since $cursor (100) > $nbProducts (4), the loop terminates.
3. Products with IDs 5 and 10 are never processed.

Expected Behavior:

• The loop should continue until all products, including the one with the maximum ID (10), have been processed.

Impact on AJAX Calls

The indexing process runs via AJAX calls, meaning the script is invoked multiple times to process products in chunks. Due to premature termination:

• Additional AJAX calls: Each time the loop stops prematurely, a new AJAX call is required, increasing overhead.
• Inefficiency: Gaps in product IDs cause the loop to stop and restart multiple times, processing fewer products than possible per iteration.
• Longer execution time: More AJAX calls mean increased processing time due to repeated script initializations and database queries.

The solution would be to replace:

Modifica
$cursor < $nbProducts
with
$cursor < $maxProductId
here: https://github.com/PrestaShop/ps_facetedsearch/blob/e3d8f332b60a116a4e4c054a746a4df201f02621/ps_facetedsearch.php#L1581-L1585

Obviously, $maxProductId needs to be retrieved.

This is my solution: PrestaShop/ps_facetedsearch#1124