-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GH workflows: Node 14-16, PHP 7.2-8.2, Github actions v3 #902
Update GH workflows: Node 14-16, PHP 7.2-8.2, Github actions v3 #902
Conversation
@Hlavtox Feel free to bump minimum compatibility to PHP 7.1.3 and PS 1.7.7, module version to 4.0.0 as we agreed at issues/32841 when you think it's the right time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order for CI to be helpful for this module, let's consider this scenario:
- from now on we would check only for PHP 7.2 to 8.2 compatibility whereas the module is still compatible with PrestaShop 1.7.6 which should work with as low as PHP 5.6. Even PrestaShop 1.7.7 supports PHP 7.1+, so either we should have tests for PHP 7.1+, or we should bump the compatibility to PrestaShop 8.
660e625
@kpodemski As we can see in Files changed, this repo lacks of PHP 7.1 check for a long time, not after this PR. I suggested matks add it himself in Slack but he forgot or has no time to do ;) Added by the way. |
thanks @leemyongpakvn the next step it to drop support for 1.7.6 |
(9 JS warnings and 21 PHP warnings in Release v3.13.1):
https://github.com/PrestaShop/ps_facetedsearch/actions/runs/5793944220
https://github.com/PrestaShop/ps_facetedsearch/actions/runs/5793944222
This change is