Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the name of subroutines #63

Open
zhisong opened this issue Apr 10, 2019 · 3 comments
Open

Change the name of subroutines #63

zhisong opened this issue Apr 10, 2019 · 3 comments

Comments

@zhisong
Copy link
Collaborator

zhisong commented Apr 10, 2019

Stuart mentioned today that we can change the name of the subroutines that in the form of xx00aa.
The length of the new names must be 6 characters. I propose the following:
Old New Descriptions
pp00aa poinca Poincare plot
pp00ab ftrace field line tracing
ma00aa intgrl volume integrals
ma02aa bltrmi compute the local Beltrami solution
mp00ac iotait iteration over rotational transform
jo00aa flderr compute the field error
tr00ab denrgy compute the derivative of energy in each volume
sc00aa covfld compute co-variant field B
ra00aa wrtfld write vector potential to file

Please let me know if you have any ideas.

@SRHudson
Copy link
Collaborator

SRHudson commented Apr 10, 2019 via email

@zhisong
Copy link
Collaborator Author

zhisong commented Apr 10, 2019

Sorry my mistake. So we have
df00ab denrgy compute the derivative of energy in each volume for field Newton method
tr00ab iniota compute the rotational transform on the interfaces

@abaillod
Copy link
Collaborator

Hello!

I may have a suggestion on mp00ac.h and ma02aa.h. From what I understood in the code (please correct me if I am wrong...), ma02aa.h iterates on mp00ac.h to solve the beltrami field in one volume given some constraints (not necessarily iota, it can be another local constraint) and mp00ac.h solves the beltrami field given {\mu, \psi_p} and the geometry. Thus I would propose:

mp00ac bsolve Solve Beltrami field in one volume given the matrices dMA, dMB, dMD and dMG (which depend on {\mu, \psi_p} and the geometry)
ma02aa lciter Iterates on bsolve to match (local) constraint

note:
(1) I precise local constraint since I am currently working on global constraints, i.e. constraints that requires information from more than one volume to be computed (for example toroidal current). Following the terminology I used above, I will call gciter the routine which iterates on bsolve to match global constraints.
(2) If you want to keep the letters "fld" to denote the field (like in your proposal to rename ra00aa in wrtfld), we could also call mp00ac fldslv. I personaly find it a bit more obscure than bsolve!

This is only a suggestion, tell me what you think about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants