Skip to content

Conversation

@afarber
Copy link
Contributor

@afarber afarber commented Nov 15, 2025

Fix #7235 by:

  • Upgrade FlatBuffers from 24.3.25 to 25.9.23
  • Switch from "flatc --js" to "flatc --ts" with transpilation to Javascript
  • Update the import paths in test files

Tasklist

Requirements / Relations

Link any requirements here. Other pull requests this PR is based on?

@afarber afarber force-pushed the 7235-upgrade-flatbuffers branch from 1449084 to 03abe0a Compare November 15, 2025 15:57
@afarber
Copy link
Contributor Author

afarber commented Nov 16, 2025

Hi @SiarheiFedartsou, hi @DennisOSRM please review my PR.

flatc does not support generating Javascript files anymore, so I transpile Typescript to Javascript.

@afarber afarber changed the title Upgrade FlatBuffers to 25.9.23 and use Typescript workflow Upgrade FlatBuffers to 25.9.23 and use TypeScript workflow Nov 16, 2025
@afarber
Copy link
Contributor Author

afarber commented Nov 29, 2025

Hi @DennisOSRM and @SiarheiFedartsou please review my PR.

The PR modifies many files in the third_party/flatbuffers folder.

To verify, that I have not introduced any "trojan horses", you could run:

  git clone --depth 1 --branch v25.9.23 https://github.com/google/flatbuffers.git /tmp/flatbuffers-official

  for dir in include src CMakeLists.txt; do
    echo "=== Comparing $dir ==="
    diff -r "third_party/flatbuffers/$dir" "/tmp/flatbuffers-official/$dir" \
      --exclude='*.o' --exclude='*.so' --exclude='CMakeFiles' \
      --exclude='*.cmake' --exclude='Makefile' 2>/dev/null || echo "No differences"
  done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade FlatBuffers from 24.3.25 to 25.9.23

1 participant