Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove non web standard usages of CSS #23

Closed
3 tasks
thescientist13 opened this issue Dec 16, 2020 · 0 comments · Fixed by #25
Closed
3 tasks

remove non web standard usages of CSS #23

thescientist13 opened this issue Dec 16, 2020 · 0 comments · Fixed by #25
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@thescientist13
Copy link
Member

thescientist13 commented Dec 16, 2020

As a "getting started" template, it would stand to reason that it probably should only promote web standards, which in this repo is conflicted due to usages of:

  1. nested CSS
  2. import for CSS files

Examples

  1. https://github.com/ProjectEvergreen/greenwood-getting-started/blob/master/src/components/footer/footer.css
  2. https://github.com/ProjectEvergreen/greenwood-getting-started/blob/master/src/components/footer/footer.js

What we should do here is the following

  1. For any instances of import xxx from some.css, put that right into the JavaScript template, e.g.
    // create templates that interpolate variables and HTML!
    getTemplate() {
    
      return `
        <style>
          /* contents of CSS file goes here instead */
        </style>
      
        /* some HTML code */
      `;
    }
  2. Un nest any of that CSS
  3. Remove dependency on @eve-container/eve-container and replace with FlexBox / Grid equivalent

This will be important as the next version of Greenwood, while custom PostCSS plugins will still be supported, it wont be by default, so if a project wants to use nested CSS, that's great, they can by just installing it into their project.

@thescientist13 thescientist13 added enhancement New feature or request good first issue Good for newcomers labels Dec 16, 2020
@thescientist13 thescientist13 changed the title remove non standard CSS remove non standard usages of CSS Dec 16, 2020
@thescientist13 thescientist13 changed the title remove non standard usages of CSS remove non web standard usages of CSS Dec 16, 2020
@thescientist13 thescientist13 linked a pull request Dec 23, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants