linting

Author: thescientist13

.eslintrc.js

@@ -1,13 +1,13 @@
-const path = require('path');
+// const path = require('path');
 
 module.exports = {
-  parser: 'babel-eslint',
   parserOptions: {
     ecmaVersion: 2018,
-    sourceType: 'module',
-    babelOptions: {
-      configFile: path.join(__dirname, './packages/cli/src/config/babel.config.js')
-    }
+    sourceType: 'module'
+    // TODO should we use this?
+    // babelOptions: {
+    //   configFile: path.join(__dirname, './packages/cli/src/config/babel.config.js')
+    // }
   },
   env: {
     browser: true,

packages/cli/src/config/rollup.config.js

@@ -100,7 +100,7 @@ function greenwoodHtmlPlugin(compilation) {
                     // console.debug('NO MATCH?????', innerBundleId);
                     // TODO better testing
                     // TODO magic string
-                    if(innerBundleId.indexOf('.greenwood/') < 0 && !mappedBundles.get(innerBundleId)){
+                    if (innerBundleId.indexOf('.greenwood/') < 0 && !mappedBundles.get(innerBundleId)) {
                       // console.debug('NEW BUNDLE TO INJECT!');
                       newHtml = newHtml.replace(/<script type="module" src="(.*)"><\/script>/, `
                         <script type="module" src="/${innerBundleId}"></script>
@@ -127,7 +127,7 @@ function greenwoodHtmlPlugin(compilation) {
 
 module.exports = getRollupConfig = async (compilation) => {
 
-  const { scratchDir, outputDir } = compilation.context;;
+  const { scratchDir, outputDir } = compilation.context;
 
   return [{
     // TODO Avoid .greenwood/ directory, do everything in public/?

packages/cli/src/index.js

@@ -29,7 +29,7 @@ program
   .version(greenwoodPackageJson.version)
   .arguments('<script-mode>')
   .usage('<script-mode> [options]');
-  // TODO .usage(`${chalk.green('<script-mode>')} [options]`);
+// TODO .usage(`${chalk.green('<script-mode>')} [options]`);
 
 program
   .command('build')

packages/cli/src/lib/browser.js

@@ -38,7 +38,7 @@ class BrowserRunner {
 
     // only allow puppeteer to load necessary scripts needed for pre-rendering of the site itself
     page.on('request', interceptedRequest => {
-      const interceptedRequestUrl = interceptedRequest.url();
+      // const interceptedRequestUrl = interceptedRequest.url();
 
       // console.debug('request', interceptedRequestUrl);
       // TODO handle serialize only requests

packages/cli/src/lifecycles/bundle.js

@@ -16,4 +16,4 @@ module.exports = bundleCompilation = async (compilation) => {
       reject(err);
     }
   });
-}
+};

packages/cli/src/lifecycles/config.js

@@ -28,7 +28,8 @@ module.exports = readAndMergeConfig = async() => {
 
       if (await fs.exists(path.join(process.cwd(), 'greenwood.config.js'))) {
         const userCfgFile = require(path.join(process.cwd(), 'greenwood.config.js'));
-        const { workspace, devServer, optimization, publicPath, title, meta, plugins, themeFile, markdown } = userCfgFile;
+        // TODO const { workspace, devServer, optimization, publicPath, title, meta, plugins, themeFile, markdown } = userCfgFile;
+        const { workspace, devServer, publicPath, title, meta } = userCfgFile;
 
         // workspace validation
         if (workspace) {

packages/cli/src/lifecycles/copy.js

@@ -3,12 +3,12 @@ const fsPromises = fs.promises;
 const path = require('path');
 
 async function rreaddir (dir, allFiles = []) {
-  const files = (await fsPromises.readdir(dir)).map(f => path.join(dir, f))
+  const files = (await fsPromises.readdir(dir)).map(f => path.join(dir, f));
 
   allFiles.push(...files);
 
   await Promise.all(files.map(async f => (
-    (await fsPromises.stat(f)).isDirectory() && rreaddir(f, allFiles)
+    await fsPromises.stat(f)).isDirectory() && rreaddir(f, allFiles
   )));
 
   return allFiles;
@@ -43,7 +43,7 @@ module.exports = copyAssets = (compilation) => {
         console.info('copying assets/ directory...');
         const assetPaths = await rreaddir(`${context.userWorkspace}/assets`);
 
-        if (assetPaths.length > 0){
+        if (assetPaths.length > 0) {
           if (!fs.existsSync(`${context.outputDir}/assets`)) {
             fs.mkdirSync(`${context.outputDir}/assets`);
           }
@@ -54,15 +54,15 @@ module.exports = copyAssets = (compilation) => {
 
             if (isDirectory && !fs.existsSync(target)) {
               fs.mkdirSync(target);
-            } else if(!isDirectory){
+            } else if (!isDirectory) {
               return asset;
             }
           }).map((asset) => {
             const target = asset.replace(context.userWorkspace, context.outputDir);
 
             return copyFile(asset, target);
           }));
-        };
+        }
       }
 
       // TODO should be done via rollup detection, so Greenwood will only copy files used when actually imported by the user
@@ -95,4 +95,4 @@ module.exports = copyAssets = (compilation) => {
       reject(err);
     }
   });
-}
+};

packages/cli/src/lifecycles/graph.js

@@ -1,7 +1,7 @@
 #!/usr/bin/env node
 const fs = require('fs-extra');
 const { promises: fsp } = require('fs');
-const crypto = require('crypto');  // TODO pretty heavy just for some hashing?
+const crypto = require('crypto'); // TODO pretty heavy just for some hashing?
 const path = require('path');
 const fm = require('front-matter');
 const toc = require('markdown-toc');
@@ -154,7 +154,7 @@ const createGraphFromPages = async (pagesDir, config) => {
               }
 
               // TODO handle top level root index.html
-              if (ishtmlFile){
+              if (ishtmlFile) {
                 // const { label, template, title } = attributes;
                 // const { meta } = config;
 

packages/cli/src/lifecycles/serialize.js

@@ -43,8 +43,8 @@ module.exports = serializeCompilation = async (compilation) => {
             }
 
             await fsp.writeFile(path.join(outputDir, outputPath), htmlModified);
-        });
-      }))
+          });
+      }));
     } catch (e) {
       // eslint-disable-next-line no-console
       console.error(err);
@@ -72,4 +72,4 @@ module.exports = serializeCompilation = async (compilation) => {
       reject(err);
     }
   });
-}
+};

www/components/header/header.js

@@ -43,7 +43,7 @@ class HeaderComponent extends LitElement {
         }).sort((a, b) => {
           return a.data.index < b.data.index ? -1 : 1;
         });
-    });
+      });
   }
 
   /* eslint-disable indent */

www/components/shelf/shelf.js

@@ -110,14 +110,14 @@ class Shelf extends LitElement {
           return a.data.index < b.data.index ? -1 : 1;
         });
       });
-      // return await client.query({
-      //   query: MenuQuery,
-      //   variables: {
-      //     name: 'side',
-      //     route: `/${this.page}/`,
-      //     order: 'index_asc'
-      //   }
-      // });
+    // return await client.query({
+    //   query: MenuQuery,
+    //   variables: {
+    //     name: 'side',
+    //     route: `/${this.page}/`,
+    //     order: 'index_asc'
+    //   }
+    // });
   }
 
   async updated(changedProperties) {
@@ -140,10 +140,10 @@ class Shelf extends LitElement {
       if (list && list.length > 0) {
         listItems = html`
           <ul>
-            ${list.map((item, index) => {
+            ${list.map((item) => {
               return html`
                 <li class="${selected ? '' : 'hidden'}">
-                  <a @click=${() => { this.goTo(`${item.route}`) }}>${item.label}</a>
+                  <a @click=${() => { this.goTo(`${item.route}`); }}>${item.label}</a>
                 </li>
               `;
             })}