Fix incorrectly disabled "Max LOQ CV" text box (#3390)

Fixed "Max LOQ CV" text box incorrectly disabled when LOD calculation is "Bilinear turning point" (reported by Philip) The "Max LOQ CV" text box needed to be disabled when the limit of quantification was being calculated using bootstrap curves. Now that LOQ is no longer calculated with using bootstrap curves, the text box should always be enabled.

Also fix performance problem pasting a large number of values into Document Grid in very large document (not reported by anyone).
Also fix performance problem I introduced earlier this week reading ResultFileMetadata

Author: nickshulman

pwiz_tools/Skyline/Model/Databinding/SkylineDataSchema.cs

@@ -47,9 +47,9 @@ private readonly HashSet<IDocumentChangeListener> _documentChangedEventHandlers
             = new HashSet<IDocumentChangeListener>();
         private readonly CachedValue<ImmutableSortedList<ResultKey, Replicate>> _replicates;
         private readonly CachedValue<IDictionary<ResultFileKey, ResultFile>> _resultFiles;
-        private readonly CachedValue<ElementRefs> _elementRefCache;
         private readonly CachedValue<AnnotationCalculator> _annotationCalculator;
         private readonly CachedValue<NormalizedValueCalculator> _normalizedValueCalculator;
+        private ElementRefs _elementRefCache;
 
         private BatchChangesState _batchChangesState;
 
@@ -62,7 +62,6 @@ public SkylineDataSchema(IDocumentContainer documentContainer, DataSchemaLocaliz
 
             _replicates = CachedValue.Create(this, CreateReplicateList);
             _resultFiles = CachedValue.Create(this, CreateResultFileList);
-            _elementRefCache = CachedValue.Create(this, () => new ElementRefs(Document));
             _annotationCalculator = CachedValue.Create(this, () => new AnnotationCalculator(this));
             _normalizedValueCalculator = CachedValue.Create(this, () => new NormalizedValueCalculator(Document));
         }
@@ -228,6 +227,10 @@ private void DocumentChangedEventHandler(object sender, DocumentChangedEventArgs
             using (QueryLock.CancelAndGetWriteLock())
             {
                 _document = _documentContainer.Document;
+                if (!_document.DeferSettingsChanges)
+                {
+                    _elementRefCache = null;
+                }
                 IList<IDocumentChangeListener> listeners;
                 lock (_documentChangedEventHandlers)
                 {
@@ -263,7 +266,15 @@ public Lazy<NormalizationData> LazyNormalizationData
         }
 
         public ChromDataCache ChromDataCache { get; private set; }
-        public ElementRefs ElementRefs { get { return _elementRefCache.Value; } }
+
+        public ElementRefs ElementRefs
+        {
+            get
+            {
+                _elementRefCache ??= new ElementRefs(Document);
+                return _elementRefCache;
+            }
+        }
 
         public AnnotationCalculator AnnotationCalculator
         {

pwiz_tools/Skyline/Model/Results/Spectra/SpectrumMetadatas.cs

@@ -281,7 +281,7 @@ public override int GetHashCode()
             return CollectionUtil.GetHashCodeDeep(this);
         }
 
-        private struct PrecursorWithLevel
+        private readonly struct PrecursorWithLevel : IEquatable<PrecursorWithLevel>
         {
             public PrecursorWithLevel(int msLevel, SpectrumPrecursor spectrumPrecursor)
             {
@@ -291,6 +291,24 @@ public PrecursorWithLevel(int msLevel, SpectrumPrecursor spectrumPrecursor)
 
             public int MsLevel { get; }
             public SpectrumPrecursor Precursor { get; }
+
+            public bool Equals(PrecursorWithLevel other)
+            {
+                return MsLevel == other.MsLevel && Precursor.Equals(other.Precursor);
+            }
+
+            public override bool Equals(object obj)
+            {
+                return obj is PrecursorWithLevel other && Equals(other);
+            }
+
+            public override int GetHashCode()
+            {
+                unchecked
+                {
+                    return (MsLevel * 397) ^ Precursor.GetHashCode();
+                }
+            }
         }
 
         private struct ScanId

pwiz_tools/Skyline/SettingsUI/PeptideSettingsUI.Designer.cs

@@ -2115,11 +2115,6 @@ private void listLibraries_MouseMove(object sender, MouseEventArgs e)
             ChangeTooltip(listLibraries, librarySpec?.ItemDescription?.ToString() ?? _librariesOriginalTooltip);
         }
 
-        private void comboLodMethod_SelectedIndexChanged(object sender, EventArgs e)
-        {
-            tbxMaxLoqBias.Enabled = comboLodMethod.SelectedItem != LodCalculation.TURNING_POINT_STDERR;
-        }
-
         private void comboRegressionFit_SelectedIndexChanged(object sender, EventArgs e)
         {
             UpdateLodOptions(comboLodMethod.SelectedItem as LodCalculation);