Skip to content

Commit ff3d22e

Browse files
authored
Fix for previous attempt to avoid launching parallel test nodes when they aren't needed - even with a single test, if multiple languages are selected then parallel can be useful (#3377)
1 parent 207c92d commit ff3d22e

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

pwiz_tools/Skyline/SkylineTester/TabTests.cs

+2-1
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,8 @@ public override bool Run()
107107
if (GetTestList().Length > 0)
108108
args.Append(" perftests=on"); // In case any perf tests were explicitly selected - no harm if they weren't
109109

110-
if (MainWindow.RunParallel.Checked && GetTestCount() > 1) // No need for parallel on a single test
110+
if (MainWindow.RunParallel.Checked &&
111+
GetTestCount()*cultures.Count > 1) // No need to fire up parallel nodes on a single test in single culture
111112
{
112113
// CONSIDER: Should we add a checkbox for this?
113114
// args.Append(" keepworkerlogs=1"); // For debugging startup issues. Look for TestRunner-docker-worker_#-docker.log files in pwiz root

0 commit comments

Comments
 (0)