Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Multisig v2 does not check for well-formed transactio #16630

Open
wnhedaxx opened this issue Dec 5, 2023 · 1 comment
Open

[Bug] Multisig v2 does not check for well-formed transactio #16630

wnhedaxx opened this issue Dec 5, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@wnhedaxx
Copy link

wnhedaxx commented Dec 5, 2023

🐛 Bug Report

When submitting a single-signer transaction, the CLI/REST client check that a transaction is well formed, e.g. that the public entry function call corresponds to an existing function and has proper arguments/type arguments

However, when submitting a transaction proposal for multisig v2, there is no such well-formed check, rather, the multisig v2 appears to simply accept for the transaction payload an arbitrary bytestring, e.g. a function call with any combination of type args/args

This can create headaches during the multisig flow, where transactions need to be rejected after faulty submission, even though the underlying proposed transaction could've been rejected upon proposal, since it was not well-formed

(This does not apply for creating a txn proposal with payload hash only)

@wnhedaxx wnhedaxx added the bug Something isn't working label Dec 5, 2023
@wnhedaxx
Copy link
Author

wnhedaxx commented Dec 7, 2023

@d0cd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant