fix: revert Boolean wire format to string, keep __init__ variable name

Author: NOisi-X

roborock/devices/traits/a01/__init__.py

@@ -71,7 +71,7 @@
 
 _LOGGER = logging.getLogger(__name__)
 
-__all__ = [
+__init__ = [
     "DyadApi",
     "ZeoApi",
     "ZeoFeatureTrait",
@@ -119,16 +119,17 @@ def _decode_expansion_type(val: Any, default: int) -> int:
     return int(val) if val is not None else default
 
 
-def to_dp_bool(val: Any) -> int:
-    """Normalise a boolean-like value to the wire-format integer ``1`` or ``0``.
+def to_dp_bool(val: Any) -> str:
+    """Normalise a boolean-like value to the wire-format string ``"True"`` or ``"False"``.
 
-    Used only in the ``set_value`` encoder path because callers (HA switch
-    entities, external code) may pass Python ``True`` / ``False`` which
-    ``json.dumps`` would serialise as JSON ``true`` / ``false`` — not the
-    integer ``1`` / ``0`` that the device expects.  Cache‑reading paths
-    do NOT need this: MQTT push already delivers integers.
+    The official app serialises booleans as the strings ``"True"`` /
+    ``"False"`` (its ``DPBoolean`` enum) on SET commands — not as ``1`` / ``0``
+    or JSON ``true`` / ``false``.  Used only in the ``set_value`` encoder
+    path because callers (HA switch entities, external code) may pass
+    Python ``True`` / ``False`` which ``json.dumps`` would serialise as
+    JSON ``true`` / ``false``.
     """
-    return 1 if parse_bool(val) else 0
+    return "True" if parse_bool(val) else "False"
 
 
 DYAD_PROTOCOL_ENTRIES: dict[RoborockDyadDataProtocol, Callable] = {
@@ -687,13 +688,13 @@ async def start(self) -> dict[RoborockZeoProtocol, Any]:
         then call ``start()`` to commit and launch.
 
         For pausing / resuming, use :meth:`resume` which sends only
-        ``START = 1`` without re‑bundling parameters."""
+        ``START = "True"`` without re‑bundling parameters."""
         _LOGGER.debug("Start command: discovering features and building payload")
         await self._feature_trait.refresh()
         features = self._feature_trait.features
         p = await self._get_start_params()
         dps: dict[RoborockZeoProtocol, Any] = {
-            RoborockZeoProtocol.START: 1,
+            RoborockZeoProtocol.START: "True",
             RoborockZeoProtocol.MODE: p.mode,
             RoborockZeoProtocol.PROGRAM: p.program,
         }
@@ -722,7 +723,7 @@ async def start(self) -> dict[RoborockZeoProtocol, Any]:
         return await send_decoded_command(self._channel, dps, value_encoder=lambda x: x, qos=MqttQos.AT_LEAST_ONCE)
 
     async def resume(self) -> dict[RoborockZeoProtocol, Any]:
-        """Resume a paused cycle — sends only ``START = 1``.
+        """Resume a paused cycle — sends only ``START = "True"``.
 
         Matches the official app's ``continue()`` / ``start()``
         (simple single-DP version).  Unlike :meth:`start`, this does
@@ -731,7 +732,7 @@ async def resume(self) -> dict[RoborockZeoProtocol, Any]:
         progress.  ``continue`` is a Python keyword so the method is
         named ``resume``.
         """
-        dps: dict[RoborockZeoProtocol, Any] = {RoborockZeoProtocol.START: 1}
+        dps: dict[RoborockZeoProtocol, Any] = {RoborockZeoProtocol.START: "True"}
         return await send_decoded_command(self._channel, dps, value_encoder=lambda x: x, qos=MqttQos.AT_LEAST_ONCE)
 
     # ── Custom programme (DP 222 bitfield) ──────────────────────────
@@ -951,7 +952,7 @@ async def start_with_preset(self, countdown_minutes: int) -> dict[RoborockZeoPro
         features = self._feature_trait.features
         p = await self._get_start_params()
         dps: dict[RoborockZeoProtocol, Any] = {
-            RoborockZeoProtocol.START: 1,
+            RoborockZeoProtocol.START: "True",
             RoborockZeoProtocol.MODE: p.mode,
             RoborockZeoProtocol.PROGRAM: p.program,
         }

roborock/roborock_message.py

@@ -126,7 +126,7 @@ class RoborockDyadDataProtocol(RoborockEnum):
 
 class RoborockZeoProtocol(RoborockEnum):
     # ── Control actions ───────────────────────────────────────────
-    START = 200  # rw  [action → start()]  set_value(START,1) triggers bundled start()
+    START = 200  # rw  [action → start()]  set_value(START,"True") triggers bundled start()
     PAUSE = 201  # rw
     SHUTDOWN = 202  # rw
 

tests/devices/test_a01_code_review.py

@@ -70,7 +70,7 @@ def test_parse_bool_trap_is_avoided():
 
 @pytest.mark.parametrize(
     ("val", "expected"),
-    [(True, 1), (False, 0), (1, 1), (0, 0), ("True", 1), ("False", 0)],
+    [(True, "True"), (False, "False"), (1, "True"), (0, "False"), ("True", "True"), ("False", "False")],
 )
 def test_to_dp_bool(val, expected):
     assert to_dp_bool(val) == expected, f"to_dp_bool({val!r}) should be {expected}"
@@ -178,10 +178,10 @@ def test_zeo_features_all_bits_clear_decodes_all_false():
 
 
 @pytest.mark.asyncio
-async def test_zeo_set_value_bool_serialises_as_int(mock_channel):
+async def test_zeo_set_value_bool_serialises_as_string(mock_channel):
     with patch("roborock.devices.traits.a01.send_decoded_command", new_callable=AsyncMock) as mock_send:
         api = ZeoApi(mock_channel)
-        for py_val, wire in ((True, 1), (False, 0), (1, 1), (0, 0)):
+        for py_val, wire in ((True, "True"), (False, "False"), (1, "True"), (0, "False")):
             await api.set_value(RoborockZeoProtocol.UV_LIGHT, py_val)
             args, kwargs = mock_send.call_args
             params = args[1]
@@ -192,20 +192,20 @@ async def test_zeo_set_value_bool_serialises_as_int(mock_channel):
 
 
 @pytest.mark.asyncio
-async def test_dyad_set_value_bool_serialises_as_int(mock_channel):
+async def test_dyad_set_value_bool_serialises_as_string(mock_channel):
     with patch("roborock.devices.traits.a01.send_decoded_command", new_callable=AsyncMock) as mock_send:
         api = DyadApi(mock_channel)
         await api.set_value(RoborockDyadDataProtocol.SILENT_MODE, True)
         args, kwargs = mock_send.call_args
         params = args[1]
         encoder = kwargs.get("value_encoder")
         encoded = {k: (encoder(v) if encoder else v) for k, v in params.items()}
-        assert encoded[RoborockDyadDataProtocol.SILENT_MODE] == 1
+        assert encoded[RoborockDyadDataProtocol.SILENT_MODE] == "True"
 
 
 @pytest.mark.asyncio
-async def test_zeo_start_sends_int_and_bundles_core_params(mock_channel):
-    """start() must send START=1 (int), not a string or JSON boolean."""
+async def test_zeo_start_sends_true_and_bundles_core_params(mock_channel):
+    """start() must send START="True" (DPBoolean.True), not an integer."""
     mock_channel.subscribe = AsyncMock(return_value=Mock())
 
     captured = []
@@ -244,7 +244,7 @@ async def _side_effect(channel, params, **kwargs):
     ]
     assert set_calls, "start() should issue a SET command"
     start_params = set_calls[-1]
-    assert start_params[RoborockZeoProtocol.START] == 1
+    assert start_params[RoborockZeoProtocol.START] == "True"
     # Core numeric params travel as integers, not strings.
     assert start_params[RoborockZeoProtocol.MODE] == 1
     assert start_params[RoborockZeoProtocol.PROGRAM] == 1