fix: resolve remaining marketplace review source-code warnings

- drop type assertions the compiler no longer needs, including the SDK
  effortLevel workaround that @qoder-ai/qoder-agent-sdk 1.0.16 made
  obsolete
- stop awaiting the void leaf.detach() in duplicate-leaf cleanup
- bind child.kill instead of extracting the unbound method in the
  Windows tree-aware kill shim
- mark intentionally fire-and-forget closePersistentQuery calls with
  void in resetSession and setSessionId

Author: luoxuanzao

src/app/settings/settings-storage.ts

@@ -104,7 +104,7 @@ function normalizeKeyboardNavigation(value: unknown): KeyboardNavigationSettings
   const candidate = value as Partial<Record<keyof KeyboardNavigationSettings, unknown>>;
   const pick = (key: keyof KeyboardNavigationSettings): string =>
     typeof candidate[key] === 'string' && candidate[key]
-      ? candidate[key] as string
+      ? candidate[key]
       : defaults[key];
 
   return {

src/features/chat/chat-view.ts

@@ -61,7 +61,7 @@ export class QoderianView extends ItemView {
     // overwritten by prototype patching. Hover Editor patches QoderianView.prototype.load
     // after our class is defined, but instance methods take precedence over prototype methods.
     const prototype = Object.getPrototypeOf(this) as LoadableView;
-    const originalLoad = prototype.load.bind(this) as () => Promise<void> | void;
+    const originalLoad = prototype.load.bind(this);
     Object.defineProperty(this, 'load', {
       value: async () => {
         // Ensure containerEl exists before any patched load code tries to use it

src/features/chat/tabs/tab-qoder-context.ts

@@ -41,7 +41,7 @@ export function getTabSettingsSnapshot(
   _tab: TabQoderContext,
   plugin: QoderianPlugin,
 ): TabQoderSettings {
-  return plugin.settings as TabQoderSettings;
+  return plugin.settings;
 }
 
 export function getTabPermissionMode(

src/features/chat/ui/status-panel.ts

@@ -129,7 +129,7 @@ export class StatusPanel {
   addBashOutput(info: PanelBashOutput): void {
     this.currentBashOutputs.set(info.id, info);
     while (this.currentBashOutputs.size > MAX_BASH_OUTPUTS) {
-      const oldest = this.currentBashOutputs.keys().next().value as string | undefined;
+      const oldest = this.currentBashOutputs.keys().next().value;
       if (!oldest) break;
       this.currentBashOutputs.delete(oldest);
       this.bashEntryExpanded.delete(oldest);

src/main.ts

@@ -202,7 +202,7 @@ export default class QoderianPlugin extends Plugin {
     for (const leaf of leaves) {
       if (leaf === keepLeaf) continue;
       try {
-        await leaf.detach();
+        leaf.detach();
       } catch {
         // Best-effort cleanup; the leaf may already be detached.
       }

src/qoder/history/qoder-conversation-history-service.ts

@@ -307,7 +307,7 @@ function sanitizeQoderState(
     return undefined;
   }
 
-  return Object.fromEntries(sanitizedEntries) as QoderState;
+  return Object.fromEntries(sanitizedEntries);
 }
 
 export function buildPersistedQoderState(

src/qoder/runtime/custom-spawn.ts

@@ -73,9 +73,7 @@ function installTreeAwareKill(child: ChildProcess, spawnSpec: WindowsCmdShimSpaw
     return;
   }
 
-  const originalKill = child.kill;
-  const callOriginalKill = (signal?: NodeJS.Signals | number): boolean =>
-    originalKill.call(child, signal);
+  const callOriginalKill = child.kill.bind(child);
   const killableChild = {
     get pid(): number | undefined {
       return child.pid;

src/qoder/runtime/qoder-chat-runtime.ts

@@ -1178,7 +1178,7 @@ export class QoderChatRuntime implements ChatRuntime {
    */
   resetSession() {
     // Close persistent query (new session will use cold-start resume)
-    this.closePersistentQuery('session reset');
+    void this.closePersistentQuery('session reset');
 
     // Reset crash recovery for fresh start
     this.crashRecoveryAttempted = false;
@@ -1258,7 +1258,7 @@ export class QoderChatRuntime implements ChatRuntime {
 
     // Close synchronously when session changes
     if (sessionChanged) {
-      this.closePersistentQuery('session switch');
+      void this.closePersistentQuery('session switch');
       this.crashRecoveryAttempted = false;
     }
 

src/qoder/runtime/qoder-dynamic-updates.ts

@@ -79,9 +79,7 @@ export async function applyQoderDynamicUpdates(
   const currentEffort = deps.getCurrentConfig()?.effortLevel ?? null;
   if (effortLevel !== currentEffort) {
     try {
-      // SDK runtime accepts `max`, but the current type definition for
-      // Settings.effortLevel has not caught up yet.
-      await persistentQuery.applyFlagSettings({ effortLevel } as unknown as Parameters<Query['applyFlagSettings']>[0]);
+      await persistentQuery.applyFlagSettings({ effortLevel });
       deps.mutateCurrentConfig(config => {
         config.effortLevel = effortLevel;
       });

src/qoder/services/qoder-title-generation-service.ts

@@ -74,7 +74,7 @@ export class QoderTitleGenerationService {
     const titleModel = this.plugin.settings.titleGenerationModel || 'auto';
     if (qoderModelConfig.isKnownModel(
       titleModel,
-      this.plugin.settings as unknown as Record<string, unknown>,
+      this.plugin.settings,
     )) {
       return toQoderRuntimeModelId(titleModel);
     }