Skip to content

Commit 9737de8

Browse files
author
liuxuezhuo
committed
ci(security): downgrade dependency-review to advisory
The action cannot pass until the repository Dependency graph is enabled, which needs org admin access. Keep the review running but non-blocking (continue-on-error); introduced vulnerabilities stay gated by npm audit --omit=dev in ci.yml. Remove continue-on-error to re-gate once the Dependency graph is enabled.
1 parent f408c63 commit 9737de8

1 file changed

Lines changed: 13 additions & 13 deletions

File tree

.github/workflows/security.yml

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -28,19 +28,19 @@ jobs:
2828
- name: Analyze
2929
uses: github/codeql-action/analyze@a2983b8bed1923f44751c5c43237f479442827b3 # v3
3030

31-
# actions/dependency-review-action requires the repository's Dependency
32-
# graph to be enabled (Settings > Code security and analysis). Until an
33-
# org admin enables it, newly introduced vulnerabilities are still gated
34-
# by the "npm run audit:prod" step in ci.yml. To restore this job:
35-
#
36-
# dependency-review:
37-
# name: Dependency review
38-
# if: github.event_name == 'pull_request'
39-
# runs-on: ubuntu-latest
40-
# steps:
41-
# - uses: actions/checkout@11d5960a326750d5838078e36cf38b85af677262 # v4
42-
# - name: Review dependency changes
43-
# uses: actions/dependency-review-action@2031cfc080254a8a887f58cffee85186f0e49e48 # v4.9.0
31+
dependency-review:
32+
name: Dependency review
33+
if: github.event_name == 'pull_request'
34+
runs-on: ubuntu-latest
35+
steps:
36+
- uses: actions/checkout@11d5960a326750d5838078e36cf38b85af677262 # v4
37+
# Downgraded to advisory: this action needs the repository Dependency
38+
# graph enabled (Settings > Code security and analysis), which requires
39+
# org admin access. Once enabled, drop continue-on-error to re-gate.
40+
# Introduced vulnerabilities are still blocked by audit:prod in ci.yml.
41+
- name: Review dependency changes
42+
continue-on-error: true
43+
uses: actions/dependency-review-action@2031cfc080254a8a887f58cffee85186f0e49e48 # v4.9.0
4444

4545
secrets:
4646
name: Secret scan

0 commit comments

Comments
 (0)