Fix bug impure tensors complex phi4 + added test for impure tensors for real and complex phi4#168
Merged
VictorVanthilt merged 4 commits intoApr 16, 2026
Conversation
|
Your PR no longer requires formatting changes. Thank you for your contribution! |
Member
|
Can you lower the initial bond dimension for the test? HOTRG with chi 64 is quite heavy, even if it only is for one step. |
Member
|
The tests are taking a very long time |
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two main changes:
1 - Fix bug in complex$\phi^4$
Resolved a bug that prevented the construction of impure tensors in the complex φ⁴ model.
2 - Add test for impure tensors of both real and complex$\phi^4$
Added tests for the construction of impure tensors in both the real and complex φ⁴ models. These tests were previously missing and help ensure that impure tensor construction works correctly.
Outlook
Several other models currently do not include tests for their impure tensor construction methods. Adding similar tests for those models would further improve test coverage.