Skip to content

Stabilize cond tests by using randn#420

Merged
lkdvos merged 1 commit intomainfrom
ld-cond
Apr 28, 2026
Merged

Stabilize cond tests by using randn#420
lkdvos merged 1 commit intomainfrom
ld-cond

Conversation

@lkdvos
Copy link
Copy Markdown
Member

@lkdvos lkdvos commented Apr 28, 2026

Not sure if this makes a large difference, but this perhaps could give better conditioned matrices?

@lkdvos lkdvos linked an issue Apr 28, 2026 that may be closed by this pull request
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lkdvos lkdvos marked this pull request as ready for review April 28, 2026 11:41
@lkdvos
Copy link
Copy Markdown
Member Author

lkdvos commented Apr 28, 2026

Victory 🎉

@lkdvos lkdvos requested a review from kshyatt April 28, 2026 12:11
@lkdvos lkdvos enabled auto-merge (squash) April 28, 2026 12:12
@lkdvos lkdvos changed the title attempt to stabilizecond tests by using randn Stabilizecond tests by using randn Apr 28, 2026
@lkdvos lkdvos disabled auto-merge April 28, 2026 12:12
@lkdvos lkdvos enabled auto-merge (squash) April 28, 2026 12:12
@lkdvos lkdvos changed the title Stabilizecond tests by using randn Stabilize cond tests by using randn Apr 28, 2026
Copy link
Copy Markdown
Member

@kshyatt kshyatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hoorah

@Jutho
Copy link
Copy Markdown
Member

Jutho commented Apr 28, 2026

Approved until the next change in the Julia RNGs that requires us to switch randn -> rand again 😄 .

@lkdvos lkdvos disabled auto-merge April 28, 2026 13:22
@lkdvos lkdvos merged commit d29d4d1 into main Apr 28, 2026
68 of 75 checks passed
@lkdvos lkdvos deleted the ld-cond branch April 28, 2026 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cond test fails depending on whether --fast is used in the testsuite

3 participants