[✨] Switch from Eslint to Biome #109
Replies: 12 comments 2 replies
-
|
If the request gets enough support I will start the previously mentioned PR |
Beta Was this translation helpful? Give feedback.
-
|
yes, I want to switch to Biome asap the only concerns we have are tailwind prettier plugin and qwik eslint plugin that both need to work with Biome. If there is now a path and you're willing to work with us on a PR then I don't see why not |
Beta Was this translation helpful? Give feedback.
-
|
Hey @rogervila! This would be amazing. Biome reduces a ton of bloat and dependencies from eslint and prettier in the starters generated from the Qwik CLI, and the performance is next level. eslint-plugin-qwik to biome is what has held us back. Would love to help out on this. |
Beta Was this translation helpful? Give feedback.
-
|
@rogervila can you ping us in the discord so we can create a channel for this effort |
Beta Was this translation helpful? Give feedback.
-
|
Hey @rogervila! Any status updates? Would love to help you on this effort. |
Beta Was this translation helpful? Give feedback.
-
|
+1 Looking forward to this being shipped |
Beta Was this translation helpful? Give feedback.
-
|
Hi @thejackshelton @shirotech I will start working on it next week together with @PatrickJS :) |
Beta Was this translation helpful? Give feedback.
-
|
I'd absolutely love to use Biome instead of Eslint/prettier. But we'll need to make sure current users of |
Beta Was this translation helpful? Give feedback.
-
|
We moved this issue to |
Beta Was this translation helpful? Give feedback.
-
|
Biome is pretty awesome, but there two other fast linters in this space; shouldn't we first analyze them before switching?
|
Beta Was this translation helpful? Give feedback.
-
|
@briandiephuis imo we need to provide the 3-4 as potential options. Then the question of which one should be the default on starters, etc., will depend on the state of things. If we can get Biome support when Oxc isn't ready, I'm thinking why not use Biome as a default. But when we'll get Oxc support I can definitely see it become the default. |
Beta Was this translation helpful? Give feedback.
-
|
Hi @rogervila and everyone following this discussion! 👋 Thank you for this proposal! After reviewing this idea in our team meeting, we decided not to move it forward as an RFC right now. Supporting this feature would mean maintaining the same rules in multiple places, including in multiple languages (JS and Rust), which adds a layer of complexity. Additionally, with Oxc lint emerging as a possible alternative, we think it’s important to consider future flexibility. We did, however, decide to promote the proposal to disable the lint step from the dev server, which should significantly speed up development for Qwik apps. For now, we’d love to see the community explore implementing this as an external solution. This approach allows us to keep focusing on getting V2 out the door asap and we do want to still support ESLint, which remains widely used, and helps maintain backward compatibility. Thank you again for the suggestion, and we’re excited to support anyone interested in developing this as an external linter plugin! 🙌 |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Is your feature request related to a problem?
This feature is unrelated to any problem but represents a significant performance improvement for the build step since Biome linter is much faster than Eslint.
Biome provides a migration tool that makes it a breeze to migrate the Eslint configuration.
Describe the solution you'd like
The solution would consist of a PR with the following changes:
eslint-plugin-qwik, using Biome's migration toolpackage.jsonlintcommand to use Biome instead of Eslinteslint-plugin-qwikDescribe alternatives you've considered
AFAIK, Biome is the most performant linter on the market and, since it provides a migration tool, I have not considered other alternatives.
Additional context
Performance comparison between Eslint and Biome published on Biome's website:
Beta Was this translation helpful? Give feedback.
All reactions