chore: remove .cjs builds

.changeset/nasty-heads-check.md

@@ -0,0 +1,6 @@
+---
+'@qwik.dev/router': major
+'@qwik.dev/core': major
+---
+
+BREAKING: Qwik and Qwik Router no longer provide .cjs builds. The tooling ecosystem can now handle ESM modules well.

packages/docs/src/routes/docs/(qwik)/advanced/library/index.mdx

@@ -74,7 +74,6 @@ The most important files of a library are a properly configured `package.json` a
   "exports": {
     ".": {
       "import": "./lib/index.qwik.mjs",
-      "require": "./lib/index.qwik.cjs",
       "types": "./lib-types/index.d.ts"
     }
   },
@@ -102,8 +101,8 @@ export default defineConfig(() => {
       target: 'es2020',
       lib: {
         entry: './src/index.ts',
-        formats: ['es', 'cjs'],
-        fileName: (format) => `index.qwik.${format === 'es' ? 'mjs' : 'cjs'}`,
+        formats: ['es'],
+        fileName: 'index.qwik.mjs',
       },
     },
     plugins: [qwikVite()],

packages/qwik-router/package.json

@@ -48,63 +48,51 @@
   "exports": {
     ".": {
       "types": "./lib/index.d.ts",
-      "import": "./lib/index.qwik.mjs",
-      "require": "./lib/index.qwik.cjs"
+      "import": "./lib/index.qwik.mjs"
     },
     "./adapters/azure-swa/vite": {
       "types": "./lib/adapters/azure-swa/vite/index.d.ts",
-      "import": "./lib/adapters/azure-swa/vite/index.mjs",
-      "require": "./lib/adapters/azure-swa/vite/index.cjs"
+      "import": "./lib/adapters/azure-swa/vite/index.mjs"
     },
     "./adapters/cloudflare-pages/vite": {
       "types": "./lib/adapters/cloudflare-pages/vite/index.d.ts",
-      "import": "./lib/adapters/cloudflare-pages/vite/index.mjs",
-      "require": "./lib/adapters/cloudflare-pages/vite/index.cjs"
+      "import": "./lib/adapters/cloudflare-pages/vite/index.mjs"
     },
     "./adapters/cloud-run/vite": {
       "types": "./lib/adapters/cloud-run/vite/index.d.ts",
-      "import": "./lib/adapters/cloud-run/vite/index.mjs",
-      "require": "./lib/adapters/cloud-run/vite/index.cjs"
+      "import": "./lib/adapters/cloud-run/vite/index.mjs"
     },
     "./adapters/bun-server/vite": {
       "types": "./lib/adapters/bun-server/vite/index.d.ts",
-      "import": "./lib/adapters/bun-server/vite/index.mjs",
-      "require": "./lib/adapters/bun-server/vite/index.cjs"
+      "import": "./lib/adapters/bun-server/vite/index.mjs"
     },
     "./adapters/deno-server/vite": {
       "types": "./lib/adapters/deno-server/vite/index.d.ts",
-      "import": "./lib/adapters/deno-server/vite/index.mjs",
-      "require": "./lib/adapters/deno-server/vite/index.cjs"
+      "import": "./lib/adapters/deno-server/vite/index.mjs"
     },
     "./adapters/node-server/vite": {
       "types": "./lib/adapters/node-server/vite/index.d.ts",
-      "import": "./lib/adapters/node-server/vite/index.mjs",
-      "require": "./lib/adapters/node-server/vite/index.cjs"
+      "import": "./lib/adapters/node-server/vite/index.mjs"
     },
     "./adapters/netlify-edge/vite": {
       "types": "./lib/adapters/netlify-edge/vite/index.d.ts",
-      "import": "./lib/adapters/netlify-edge/vite/index.mjs",
-      "require": "./lib/adapters/netlify-edge/vite/index.cjs"
+      "import": "./lib/adapters/netlify-edge/vite/index.mjs"
     },
     "./adapters/shared/vite": {
       "types": "./lib/adapters/shared/vite/index.d.ts",
-      "import": "./lib/adapters/shared/vite/index.mjs",
-      "require": "./lib/adapters/shared/vite/index.cjs"
+      "import": "./lib/adapters/shared/vite/index.mjs"
     },
     "./adapters/static/vite": {
       "types": "./lib/adapters/ssg/vite/index.d.ts",
-      "import": "./lib/adapters/ssg/vite/index.mjs",
-      "require": "./lib/adapters/ssg/vite/index.cjs"
+      "import": "./lib/adapters/ssg/vite/index.mjs"
     },
     "./adapters/ssg/vite": {
       "types": "./lib/adapters/ssg/vite/index.d.ts",
-      "import": "./lib/adapters/ssg/vite/index.mjs",
-      "require": "./lib/adapters/ssg/vite/index.cjs"
+      "import": "./lib/adapters/ssg/vite/index.mjs"
     },
     "./adapters/vercel-edge/vite": {
       "types": "./lib/adapters/vercel-edge/vite/index.d.ts",
-      "import": "./lib/adapters/vercel-edge/vite/index.mjs",
-      "require": "./lib/adapters/vercel-edge/vite/index.cjs"
+      "import": "./lib/adapters/vercel-edge/vite/index.mjs"
     },
     "./middleware/azure-swa": {
       "types": "./lib/middleware/azure-swa/index.d.ts",
@@ -136,37 +124,31 @@
     },
     "./middleware/node": {
       "types": "./lib/middleware/node/index.d.ts",
-      "import": "./lib/middleware/node/index.mjs",
-      "require": "./lib/middleware/node/index.cjs"
+      "import": "./lib/middleware/node/index.mjs"
     },
     "./middleware/request-handler": {
       "types": "./lib/middleware/request-handler/index.d.ts",
-      "import": "./lib/middleware/request-handler/index.mjs",
-      "require": "./lib/middleware/request-handler/index.cjs"
+      "import": "./lib/middleware/request-handler/index.mjs"
     },
     "./middleware/vercel-edge": {
       "types": "./lib/middleware/vercel-edge/index.d.ts",
       "import": "./lib/middleware/vercel-edge/index.mjs"
     },
     "./static": {
       "types": "./lib/ssg/index.d.ts",
-      "import": "./lib/ssg/index.mjs",
-      "require": "./lib/ssg/index.cjs"
+      "import": "./lib/ssg/index.mjs"
     },
     "./ssg": {
       "types": "./lib/ssg/index.d.ts",
-      "import": "./lib/ssg/index.mjs",
-      "require": "./lib/ssg/index.cjs"
+      "import": "./lib/ssg/index.mjs"
     },
     "./vite": {
       "types": "./lib/vite/index.d.ts",
-      "import": "./lib/vite/index.mjs",
-      "require": "./lib/vite/index.cjs"
+      "import": "./lib/vite/index.mjs"
     },
     "./service-worker": {
       "types": "./service-worker.d.ts",
-      "import": "./lib/service-worker.mjs",
-      "require": "./lib/service-worker.cjs"
+      "import": "./lib/service-worker.mjs"
     },
     "./package.json": "./package.json"
   },

packages/qwik-router/src/buildtime/vite/plugin.ts

@@ -46,7 +46,6 @@ function qwikRouterPlugin(userOpts?: QwikRouterVitePluginOptions): any {
   let mdxTransform: MdxTransform | null = null;
   let rootDir: string | null = null;
   let qwikPlugin: QwikVitePlugin | null;
-  let ssrFormat: 'esm' | 'cjs' = 'esm';
   let outDir: string | null = null;
   let viteCommand: string;
   let devServer: ViteDevServer | null = null;
@@ -159,10 +158,6 @@ function qwikRouterPlugin(userOpts?: QwikRouterVitePluginOptions): any {
         return getRouteImports(ctx!.routes, manifest);
       });
 
-      // @ts-ignore `format` removed in Vite 5
-      if (config.ssr?.format === 'cjs') {
-        ssrFormat = 'cjs';
-      }
       outDir = config.build?.outDir;
     },
 
@@ -331,7 +326,7 @@ function qwikRouterPlugin(userOpts?: QwikRouterVitePluginOptions): any {
       sequential: true,
       async handler() {
         if (ctx?.target === 'ssr' && outDir) {
-          await generateServerPackageJson(outDir, ssrFormat);
+          await generateServerPackageJson(outDir);
         }
       },
     },
@@ -340,7 +335,7 @@ function qwikRouterPlugin(userOpts?: QwikRouterVitePluginOptions): any {
   return plugin;
 }
 
-async function generateServerPackageJson(outDir: string, ssrFormat: 'esm' | 'cjs') {
+async function generateServerPackageJson(outDir: string) {
   await fs.promises.mkdir(outDir, { recursive: true });
   const serverPackageJsonPath = join(outDir, 'package.json');
 
@@ -357,7 +352,7 @@ async function generateServerPackageJson(outDir: string, ssrFormat: 'esm' | 'cjs
 
   packageJson = {
     ...packageJson,
-    type: ssrFormat == 'cjs' ? 'commonjs' : 'module',
+    type: 'module',
   };
   const serverPackageJsonCode = JSON.stringify(packageJson, null, 2);
 

packages/qwik-router/vite.config.mts

@@ -48,15 +48,6 @@ export default defineConfig(() => {
             entryFileNames: (chunkInfo) =>
               chunkInfo.name === 'index' ? '[name].qwik.mjs' : '[name]/index.mjs',
           },
-          {
-            format: 'cjs',
-            chunkFileNames: (chunkInfo) =>
-              chunkInfo.moduleIds.some((id) => id.includes('runtime'))
-                ? 'chunks/[name].qwik.cjs'
-                : 'chunks/[name].cjs',
-            entryFileNames: (chunkInfo) =>
-              chunkInfo.name === 'index' ? '[name].qwik.cjs' : '[name]/index.cjs',
-          },
         ],
         external: [
           /node:.*/,

packages/qwik/package.json

@@ -35,11 +35,6 @@
         "production": "./dist/core.prod.mjs",
         "min": "./dist/core.min.mjs",
         "default": "./dist/core.prod.mjs"
-      },
-      "require": {
-        "development": "./dist/core.cjs",
-        "production": "./dist/core.prod.cjs",
-        "default": "./dist/core.prod.cjs"
       }
     },
     "./cli": {
@@ -53,11 +48,6 @@
         "production": "./dist/core.prod.mjs",
         "min": "./dist/core.min.mjs",
         "default": "./dist/core.prod.mjs"
-      },
-      "require": {
-        "development": "./dist/core.cjs",
-        "production": "./dist/core.prod.cjs",
-        "default": "./dist/core.prod.cjs"
       }
     },
     "./jsx-runtime": {
@@ -67,11 +57,6 @@
         "production": "./dist/core.prod.mjs",
         "min": "./dist/core.min.mjs",
         "default": "./dist/core.prod.mjs"
-      },
-      "require": {
-        "development": "./dist/core.cjs",
-        "production": "./dist/core.prod.cjs",
-        "default": "./dist/core.prod.cjs"
       }
     },
     "./jsx-dev-runtime": {
@@ -81,11 +66,6 @@
         "production": "./dist/core.prod.mjs",
         "min": "./dist/core.min.mjs",
         "default": "./dist/core.mjs"
-      },
-      "require": {
-        "development": "./dist/core.cjs",
-        "production": "./dist/core.prod.cjs",
-        "default": "./dist/core.cjs"
       }
     },
     "./build": {
@@ -94,50 +74,36 @@
         "development": "./dist/build/index.dev.mjs",
         "production": "./dist/build/index.prod.mjs",
         "default": "./dist/build/index.mjs"
-      },
-      "require": {
-        "development": "./dist/build/index.dev.cjs",
-        "production": "./dist/build/index.prod.cjs",
-        "default": "./dist/build/index.cjs"
       }
     },
     "./loader": {
       "types": "./dist/loader/index.d.ts",
-      "import": "./dist/loader/index.mjs",
-      "require": "./dist/loader/index.cjs"
+      "import": "./dist/loader/index.mjs"
     },
     "./insights": {
       "types": "./dist/insights.d.ts",
-      "import": "./dist/insights/index.qwik.mjs",
-      "require": "./dist/insights/index.qwik.cjs"
+      "import": "./dist/insights/index.qwik.mjs"
     },
     "./insights/vite": {
       "types": "./dist/insights/vite.d.ts",
-      "import": "./dist/insights/vite/index.mjs",
-      "require": "./dist/insights/vite/index.cjs"
+      "import": "./dist/insights/vite/index.mjs"
     },
-    "./optimizer.cjs": "./dist/optimizer.cjs",
     "./optimizer.mjs": "./dist/optimizer.mjs",
     "./optimizer": {
       "types": "./dist/optimizer.d.ts",
-      "import": "./dist/optimizer.mjs",
-      "require": "./dist/optimizer.cjs"
+      "import": "./dist/optimizer.mjs"
     },
     "./preloader": {
-      "import": "./dist/preloader.mjs",
-      "require": "./dist/preloader.cjs"
+      "import": "./dist/preloader.mjs"
     },
-    "./server.cjs": "./dist/server.cjs",
     "./server.mjs": "./dist/server.mjs",
     "./server": {
       "types": "./server.d.ts",
-      "import": "./dist/server.mjs",
-      "require": "./dist/server.cjs"
+      "import": "./dist/server.mjs"
     },
     "./testing": {
       "types": "./dist/testing/index.d.ts",
-      "import": "./dist/testing/index.mjs",
-      "require": "./dist/testing/index.cjs"
+      "import": "./dist/testing/index.mjs"
     },
     "./qwikloader.js": "./dist/qwikloader.js",
     "./qwikloader.debug.js": "./dist/qwikloader.debug.js",
@@ -205,7 +171,9 @@
     "url": "https://github.com/QwikDev/qwik.git",
     "directory": "packages/qwik"
   },
-  "sideEffects": false,
+  "sideEffects": [
+    "./src/testing/vdom-diff.unit-util.ts"
+  ],
   "scripts": {
     "build.insights": "cd src/insights && vite build --mode lib --emptyOutDir"
   },

packages/qwik/src/backpatch-executor.ts

@@ -5,6 +5,9 @@
  * same container and applying the patches to the DOM elements.
  */
 
+// needed to make this a module and make compiled-string-plugin work
+export {};
+
 const BACKPATCH_DATA_SELECTOR = 'script[type="qwik/backpatch"]';
 
 const executorScript = document.currentScript;

packages/qwik/src/core/shared/platform/platform.ts

@@ -1,4 +1,3 @@
-// keep this import from core/build so the cjs build works
 import { isServer } from '@qwik.dev/core/build';
 import { QError, qError } from '../error/error';
 import { getSymbolHash } from '../qrl/qrl-utils';

packages/qwik/src/core/shared/serdes/serialize.ts

@@ -1,6 +1,6 @@
 import { isDev } from '@qwik.dev/core/build';
-import { VNodeDataFlag } from 'packages/qwik/src/server/types';
-import type { VNodeData } from 'packages/qwik/src/server/vnode-data';
+import { VNodeDataFlag } from '../../../server/types';
+import type { VNodeData } from '../../../server/vnode-data';
 import { vnode_isVNode } from '../../client/vnode';
 import { _EFFECT_BACK_REF } from '../../internal';
 import { AsyncComputedSignalImpl } from '../../reactive-primitives/impl/async-computed-signal-impl';