[AMDGPU][WaveTransform] Enable SIOptimizeExecMaskingPreRA pass for new pipeline. #412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pipeline This patch introduces SIOptimizeExecMaskingPreRA after AMDGPUWaveTransform pass, but just before SGPR allocation to reduce register pressure for the new pipeline. While at the same time, it still acts as pre-RA pass optimizing EXEC-mask related instructions for legacy pipeline.
|
PSDB Build Link: http://mlse-bdc-20dd129:8065/#/builders/10/builds/11 |
vg0204
deleted the
amd/dev/vikashgu/enable-SiOptimizeExecMaskingPreRA-waveTransform-pipeline
branch
cdevadas
reviewed
Oct 29, 2025
| // instructions that cause scheduling barriers. | ||
| insertPass(&MachineSchedulerID, &SIWholeQuadModeID); | ||
|
|
||
| if (!LateWaveTransform && OptExecMaskPreRA) |
There was a problem hiding this comment.
Don't change the default behavior. This has to be retained.
| addPass(&RegisterCoalescerID); | ||
| } | ||
|
|
||
| if (OptExecMaskPreRA) |
There was a problem hiding this comment.
Move it inside the LateWaveTransform check.
vg0204
restored the
amd/dev/vikashgu/enable-SiOptimizeExecMaskingPreRA-waveTransform-pipeline
branch
vg0204
deleted the
amd/dev/vikashgu/enable-SiOptimizeExecMaskingPreRA-waveTransform-pipeline
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces SIOptimizeExecMaskingPreRA after AMDGPUWaveTransform pass, but just before SGPR allocation to reduce register pressure for the new pipeline. While at the same time, it still acts as pre-RA pass optimizing EXEC-mask related instructions for legacy pipeline.
It is a follow-up which depended on the #369.