-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Issue]: Recent changes to 6.0.1-112 make it ABI incompatible to 6.0.0 #152
Comments
Are you referring specifically to the fact the |
Correct.
This is a particular bad example in this case, as it does not tell the linker/runtime loader, that |
That's a great point. We expect the Question: Did it break your application? or are you just saying it should have a different version to identify the change? |
I'm just reading the code. There are at least two possible ways I know to prevent changing the soname every time a struct changes its size:
I think its too late for option 2., but 1. should still be able to add, but it wont avoid the increment in this bugfix |
@bertwesarg @oliveiradan Internal ticket has been created to fix this issue. Thanks! |
Problem Description
6.0.1-112
includes this change to therocm_smi.h
header:but this change of the size of type
rsmi_gpu_metrics_t
breaks the ABI to 6.0.0. And currently bothlibrocm_smi.so
libs have the same interface version6
.The text was updated successfully, but these errors were encountered: