Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for package configuration files #75

Open
atamazov opened this issue Jan 29, 2021 · 1 comment
Open

Add support for package configuration files #75

atamazov opened this issue Jan 29, 2021 · 1 comment
Assignees

Comments

@atamazov
Copy link

atamazov commented Jan 29, 2021

This is required for https://github.com/ROCmSoftwarePlatform/MIOpen.

Why we need rocm_smi_lib:

  • Beginning from ROCm 4.1 RC, MIOpen needs to inform offline compilers about target features (XNACK and SRAMECC).
  • Otherwise HIP/OCL runtime will fail to load code objects OR performance may suffer
  • Target features can be obtained from OpenCL and HIP runtime, but the values are valid ONLY if DKMS driver is up-to-date.
  • Therefore MIOpen needs to know the DKMS driver version.

We are going to use the library for the above purpose.

To find external packages (like compilers, libraries, etc.), MIOpen relies on CMake. However, CMake's find_package() fails to find rocm_smi_lib because it does not provide package configuration files.

We can implement our own Findrocm_smi_lib.cmake but this is not future-proof solution.

I recommend using the https://github.com/RadeonOpenCompute/rocm-cmake to implement package config files. Please refer to CMake documentation for more information.

@atamazov
Copy link
Author

/cc @dagamayank @daniellowell @t-tye

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants