Skip to content

Commit 2b49dd6

Browse files
committed
No longer infer insufficient LAPACK from libRlapack use
1 parent ae56996 commit 2b49dd6

File tree

3 files changed

+6
-13
lines changed

3 files changed

+6
-13
lines changed

configure

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -612,7 +612,6 @@ ac_subst_vars='LTLIBOBJS
612612
LIBOBJS
613613
OPENMP_FLAG
614614
ARMA_HAVE_OPENMP
615-
ARMA_LAPACK
616615
CXXCPP
617616
OBJEXT
618617
EXEEXT
@@ -3394,14 +3393,14 @@ if test x"${hasRlapack}" = x""; then
33943393
## We are using a full Lapack and can use zgbsv -- so #undef remains
33953394
{ printf "%s\n" "$as_me:${as_lineno-$LINENO}: result: system LAPACK found" >&5
33963395
printf "%s\n" "system LAPACK found" >&6; }
3397-
arma_lapack="#undef ARMA_CRIPPLED_LAPACK"
3396+
## arma_lapack="#undef ARMA_CRIPPLED_LAPACK"
33983397
else
33993398
## We are using R's subset of Lapack and CANNOT use zgbsv etc, so we mark it
34003399
{ printf "%s\n" "$as_me:${as_lineno-$LINENO}: result: R-supplied partial LAPACK found" >&5
34013400
printf "%s\n" "R-supplied partial LAPACK found" >&6; }
34023401
{ printf "%s\n" "$as_me:${as_lineno-$LINENO}: WARNING: Some complex-valued LAPACK functions may not be available" >&5
34033402
printf "%s\n" "$as_me: WARNING: Some complex-valued LAPACK functions may not be available" >&2;}
3404-
arma_lapack="#define ARMA_CRIPPLED_LAPACK 1"
3403+
## arma_lapack="#define ARMA_CRIPPLED_LAPACK 1"
34053404
fi
34063405

34073406
## Default the OpenMP flag to the empty string.
@@ -3436,8 +3435,7 @@ fi
34363435

34373436

34383437
## now use all these
3439-
ARMA_LAPACK="${arma_lapack}"
3440-
3438+
## AC_SUBST([ARMA_LAPACK],["${arma_lapack}"])
34413439
ARMA_HAVE_OPENMP="${arma_have_openmp}"
34423440

34433441
OPENMP_FLAG="${openmp_flag}"

configure.ac

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -167,12 +167,12 @@ hasRlapack=$(echo ${lapack} | grep lRlapack)
167167
if test x"${hasRlapack}" = x""; then
168168
## We are using a full Lapack and can use zgbsv -- so #undef remains
169169
AC_MSG_RESULT([system LAPACK found])
170-
arma_lapack="#undef ARMA_CRIPPLED_LAPACK"
170+
## arma_lapack="#undef ARMA_CRIPPLED_LAPACK"
171171
else
172172
## We are using R's subset of Lapack and CANNOT use zgbsv etc, so we mark it
173173
AC_MSG_RESULT([R-supplied partial LAPACK found])
174174
AC_MSG_WARN([Some complex-valued LAPACK functions may not be available])
175-
arma_lapack="#define ARMA_CRIPPLED_LAPACK 1"
175+
## arma_lapack="#define ARMA_CRIPPLED_LAPACK 1"
176176
fi
177177

178178
## Default the OpenMP flag to the empty string.
@@ -204,7 +204,7 @@ fi
204204

205205

206206
## now use all these
207-
AC_SUBST([ARMA_LAPACK],["${arma_lapack}"])
207+
## AC_SUBST([ARMA_LAPACK],["${arma_lapack}"])
208208
AC_SUBST([ARMA_HAVE_OPENMP], ["${arma_have_openmp}"])
209209
AC_SUBST([OPENMP_FLAG], ["${openmp_flag}"])
210210
AC_CONFIG_FILES([inst/include/RcppArmadillo/config/RcppArmadilloConfigGenerated.h src/Makevars])

inst/include/RcppArmadillo/config/RcppArmadilloConfigGenerated.h.in

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,6 @@
2121
#ifndef RcppArmadillo__RcppArmadilloConfigGenerated__h
2222
#define RcppArmadillo__RcppArmadilloConfigGenerated__h
2323

24-
#ifndef ARMA_CRIPPLED_LAPACK
25-
// value on next line may be changed between #undef and #define by the configure script
26-
@ARMA_LAPACK@
27-
#endif
28-
2924
#ifndef ARMA_USE_OPENMP
3025
// from configure test for OpenMP based on how R is configured, and whether g++ new enough
3126
@ARMA_HAVE_OPENMP@

0 commit comments

Comments
 (0)