Skip to content

Conversation

@ben-schwen
Copy link
Member

Closes #7165

@codecov
Copy link

codecov bot commented Oct 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.13%. Comparing base (bc7f5af) to head (5921b46).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7389   +/-   ##
=======================================
  Coverage   99.13%   99.13%           
=======================================
  Files          85       85           
  Lines       16610    16610           
=======================================
  Hits        16466    16466           
  Misses        144      144           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Oct 25, 2025

  • HEAD=omp_limits stopped early for fread disk overhead improved in #6925
    Comparison Plot

Generated via commit 5921b46

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 5 minutes and 5 seconds
Installing different package versions 9 minutes and 56 seconds
Running and plotting the test cases 2 minutes and 36 seconds

Copy link
Member

@MichaelChirico MichaelChirico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to have initDTthreads() and setDTthreads() separately? Feels like they should share even more logic

@ben-schwen
Copy link
Member Author

Well setDTthreads calls initDTthreads as helper. But they have separate functions with startup initalization and runtime configuration.

@ben-schwen ben-schwen merged commit 6de436c into master Nov 2, 2025
13 checks passed
@ben-schwen ben-schwen deleted the omp_limits branch November 2, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tests 1997.14-15 fail for some values of OMP_NUM_THREADS

3 participants