Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is it worth to mark library as deprecated? #56

Open
desfero opened this issue Jun 24, 2018 · 2 comments
Open

Is it worth to mark library as deprecated? #56

desfero opened this issue Jun 24, 2018 · 2 comments

Comments

@desfero
Copy link

desfero commented Jun 24, 2018 •
edited
Loading

Context API was finally stabilized in React 16.3 and is based on react-broadcast.

Therefore, it's worth to mark this as deprecate or at least state clearly in docs that React Context API provide the same interface.

What do you think? Is there any reason not to deprecate 'react-broadcast'?
@abhinayar
Copy link

abhinayar commented Jun 25, 2018 •
edited
Loading

Only reason would be documentation which I don't see any of, so why would you need this if the React team has officially made context a first-class feature? Seems like it would only add confusion! (apparently I can't English today...)

@mjackson
Copy link
Member

I think it's worth it to state somewhere that people who are using 16.3 shouldn't have to rely on react-broadcast, and that it's just a polyfill. But people who can't upgrade to 16.3 yet will still find it useful, so "deprecated" is the wrong word.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mjackson @desfero @abhinayar