Skip to content

Commit 5c467b3

Browse files
Reorg Scala Structure
- make Eclipse and Java/Scala interop happy
1 parent 62564d6 commit 5c467b3

27 files changed

+40
-14
lines changed
Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
/**
22
* Copyright 2013 Netflix, Inc.
3-
*
3+
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
66
* You may obtain a copy of the License at
7-
*
8-
* http://www.apache.org/licenses/LICENSE-2.0
9-
*
7+
*
8+
* http://www.apache.org/licenses/LICENSE-2.0
9+
*
1010
* Unless required by applicable law or agreed to in writing, software
1111
* distributed under the License is distributed on an "AS IS" BASIS,
1212
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -18,7 +18,7 @@
1818
import rx.Observable;
1919
import rx.lang.scala.examples.Movie;
2020
import rx.lang.scala.examples.MovieLib;
21-
21+
import rx.util.functions.Action1;
2222
import static rx.lang.scala.ImplicitFunctionConversions.toScalaObservable;
2323

2424
public class MovieLibUsage {
@@ -29,13 +29,17 @@ public static void main(String[] args) {
2929
new Movie(3000),
3030
new Movie(1000),
3131
new Movie(2000)
32-
);
32+
);
3333

3434
MovieLib lib = new MovieLib(toScalaObservable(movies));
3535

36-
lib.longMovies().asJavaObservable().subscribe(m ->
37-
System.out.println("A movie of length " + m.lengthInSeconds() + "s")
38-
);
36+
lib.longMovies().asJavaObservable().subscribe(new Action1<Movie>() {
37+
38+
@Override
39+
public void call(Movie m) {
40+
System.out.println("A movie of length " + m.lengthInSeconds() + "s");
41+
}
42+
});
3943
}
4044

4145
}

language-adaptors/rxjava-scala/src/main/scala/ImplicitFunctionConversions.scala renamed to language-adaptors/rxjava-scala/src/main/scala/rx/lang/scala/ImplicitFunctionConversions.scala

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,10 @@ import rx.lang.scala._
2121
import rx.util.functions._
2222
import scala.collection.Seq
2323
import rx.lang.scala.subscriptions.Subscription
24+
import java.{lang => jlang}
25+
import scala.language.implicitConversions
26+
import rx.lang.scala.Observer
27+
import rx.lang.scala.Scheduler
2428

2529
/**
2630
* These function conversions convert between Scala functions and Rx `Func`s and `Action`s.

language-adaptors/rxjava-scala/src/main/scala/Observable.scala renamed to language-adaptors/rxjava-scala/src/main/scala/rx/lang/scala/Observable.scala

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,10 @@ package rx.lang.scala
1919

2020
import rx.util.functions.FuncN
2121
import rx.Observable.OnSubscribeFunc
22+
import rx.lang.scala.Notification
23+
import rx.lang.scala.ImplicitFunctionConversions
24+
import rx.lang.scala.Observer
25+
import rx.lang.scala.Scheduler
2226

2327

2428
/**

language-adaptors/rxjava-scala/src/main/scala/Scheduler.scala renamed to language-adaptors/rxjava-scala/src/main/scala/rx/lang/scala/Scheduler.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,14 @@ package rx.lang.scala
22

33
import java.util.Date
44
import scala.concurrent.duration.Duration
5-
import scala.language.postfixOps
65
import ImplicitFunctionConversions.scalaFunction0ProducingUnitToAction0
76
import ImplicitFunctionConversions.schedulerActionToFunc2
87
import rx.util.functions.{Action0, Action1, Func2}
98
import rx.lang.scala.subscriptions.Subscription
109

1110
/**
12-
* Represents an object that schedules units of work.
11+
* Represents an object thatimport rx.lang.scala.ImplicitFunctionConversions
12+
schedules units of work.
1313
*/
1414
trait Scheduler {
1515
def asJavaScheduler: rx.Scheduler

language-adaptors/rxjava-scala/src/main/scala/WithFilter.scala renamed to language-adaptors/rxjava-scala/src/main/scala/rx/lang/scala/WithFilter.scala

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
package rx.lang.scala
22

3+
import rx.lang.scala.ImplicitFunctionConversions
4+
5+
import ImplicitFunctionConversions.scalaBooleanFunction1ToRxBooleanFunc1
6+
import ImplicitFunctionConversions.scalaFunction1ToRxFunc1
7+
38
// Cannot yet have inner class because of this error message:
49
// "implementation restriction: nested class is not allowed in value class.
510
// This restriction is planned to be removed in subsequent releases."

language-adaptors/rxjava-scala/src/main/scala/subjects/Subject.scala renamed to language-adaptors/rxjava-scala/src/main/scala/rx/lang/scala/subjects/Subject.scala

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
package rx.lang.scala
22

3+
import rx.lang.scala.Observer
4+
35
/**
46
* A Subject is an Observable and an Observer at the same time.
57
*/

language-adaptors/rxjava-scala/src/main/scala/subscriptions/scala.scala renamed to language-adaptors/rxjava-scala/src/main/scala/rx/lang/scala/subscriptions/scala.scala

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package rx.lang
22

3+
import rx.lang.scala.Scheduler
34
package object scala {
45

56
/**

language-adaptors/rxjava-scala/src/test/scala/RxJavaDemos.scala renamed to language-adaptors/rxjava-scala/src/test/scala/rx/lang/scala/examples/RxJavaDemos.scala

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,16 @@
1616
package rx.lang.scala.examples
1717

1818
import org.scalatest.junit.JUnitSuite
19-
import scala.language.postfixOps
2019
import rx.lang.scala._
2120
import scala.concurrent.duration._
22-
import org.junit.{Before, Test, Ignore}
21+
import org.junit.Test
2322
import org.junit.Assert._
2423
import rx.lang.scala.concurrency.Schedulers
2524
import java.io.IOException
25+
import rx.lang.scala.examples.Olympics
26+
import rx.lang.scala.Notification.OnCompleted
27+
import rx.lang.scala.Notification.OnError
28+
import rx.lang.scala.Notification.OnNext
2629

2730
//@Ignore // Since this doesn't do automatic testing, don't increase build time unnecessarily
2831
class RxScalaDemo extends JUnitSuite {

language-adaptors/rxjava-scala/src/test/scala/SubscriptionTests.scala renamed to language-adaptors/rxjava-scala/src/test/scala/rx/lang/scala/examples/SubscriptionTests.scala

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
package rx.lang.scala.examples
2+
13
import org.junit.{Assert, Test}
24
import org.scalatest.junit.JUnitSuite
35
import rx.lang.scala.subscriptions.{MultipleAssignmentSubscription, CompositeSubscription, BooleanSubscription, Subscription}

language-adaptors/rxjava-scala/src/test/scala/UnitTestSuite.scala renamed to language-adaptors/rxjava-scala/src/test/scala/rx/lang/scala/examples/UnitTestSuite.scala

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
1+
package rx.lang.scala.examples
2+
13
import org.junit.{Ignore, Assert, Test}
24
import org.scalatest.junit.JUnitSuite
35
import rx.lang.scala.Observable
4-
import scala.Predef.String
56

67
class UnitTestSuite extends JUnitSuite {
78

0 commit comments

Comments
 (0)