Incompatible with Sonar.

[Git-North]

Describe the bug
Plugin is incompatible with Sonar plugin

To Reproduce

1. Install Raknetify
2. Install Sonar
3. Start Velocity Server
4. Join server using the raknet; prefix
5. "Disconnected" and log spam

Expected behavior
I expected sonar verification to work and then successfully join the server
Screenshots
if neccesary I will add them

Runtime info (please complete the following information):

• OS: Windows 11
• Minecraft version:
  • Server: Velocity
  • Client: 1.21.4
• Mod version: raknetify-velocity-0.1.0+alpha.5.139-all

Crash reports / logs
https://mclo.gs/CAUDjVT

Other mods
https://gist.github.com/Git-North/2a1d6170c7d6fe91e8c1c5f39b9e71e5

Checklist

• I am using the official version of the mod.
• I tried the latest development version but the issue persists.
• I searched for similar open issues and could not find an existing bug report on this.

Additional context

[Git-North]

jonesdevelopment/sonar#421

[ishland]

It seems that sonar is the one trying to close the connection at the very first of the pipeline, bypassing all raknetify handling.
Plus it swallows the real error when doing that.

[Git-North]

the developer from sonar states that,

"[raknetify] forgot to check if the channel is still open before performing a certain action somewhere."

I do not know if this is helpful information but it is a information

[Git-North]

They also said that when

that error

happens they do not do anything with it

[ishland]

I have checked their message, the log and their code, their plugin is definitely involved.

[ishland]

I've moved the handling of packet forwarding into Unsafe so it can handle requests even if the event is triggered at the head of the pipeline.

There's two main differences between a raknetify connection and a vanilla connection:

• The pipeline tied to the channel will convert ByteBuf into a FrameData and send it to upstream raknet handling.
• Vanilla packet framing is removed in raknetify connections, as packet length is already encoded in FrameData.

[Foxof7207]

I do have the same issue, but this time the server doesn't show up online on the server list

[Foxof7207]

Can anyone help me?

@ishland

[Foxof7207]

Is there anything new about this issue?

@ishland @Git-North @jonesdevelopment @Kroppeb @duplexsystem